search

moonlight-stream / moonlight-qt

GameStream client for PCs (Windows, Mac, Linux, and Steam Link)
GNU General Public License v3.0
10.14k stars 593 forks source link

Allow games to be hidden in Moonlight #255

Closed michellabbe closed 4 years ago

michellabbe commented 5 years ago

Describe the bug Games flagged as hidden in Geforce Experience still show up in Moonlight. This gets especially confusing when a game is detected multiple times (see additional context below)

Steps to reproduce Flag a game as hidden in GFE. It disappear from Home screen in GFE, shows as "hidden" in filters, but Moonlight ignores the hidden flag and still show the game.

Screenshots 2019-07-05_23h55_37

2019-07-05_23h41_17

2019-07-05_23h38_58

Affected games The Elder Scrolls Online (most likely any games)

Other Moonlight clients Android (see issue #351)

Client PC details

Server PC details

Moonlight Logs Moonlight-1562381530.log

Additional context I bought The Elder Scrolls Online via Steam, and since it's linked to my Steam account it's much less annoying to launch the game from Steam (auto-logon) than standalone with username and (complex) password that need to be typed manually on every launch.

GeForce Experience detects the game as standalone (and twice for some reason): ...\Steam\steamapps\common\Zenimax Online\ and ...\steam\steamapps\common\zenimax online\launcher..\

Both copies of the same game show up with the same name and same icon in Moonlight so you don't know which is which (that's how they also show up in GFE so not being able to rename them or change icon is more a GFE annoyance than a Moonlight issue). Flagging one copy as favorite in GFE doesn't help either to determine which copy is which in Moonlight.

To be able to start the game from Steam (with auto-logon working), I had to create a game shortcut from Steam (target = "steam://rungameid/306130" instead of path/launcher.exe) and add this shortcut to GeForce Experience, then edit it and set a custom icon. This works great, but even though I hide the other copies of the same game in GFE, Moonlight ignores the hidden flag and show them anyway.

There are other reasons why you may want to hide games (e.g. hide games that won't work 100% with a gamepad).

cgutman commented 5 years ago

There is no "hidden" flag in the appdata XML, so we have no clue that the app should be hidden or not. This is a bug for Nvidia, not us.

michellabbe commented 5 years ago

Thanks for the (quick!) reply.

I guess NVIDIA only officially support their Shield device as a GameStream client so it's not quite worth filling a bug report over there unless some Shield owner complains about it on the Shield also.

Would it make sense as a feature request to hide games directly in Moonlight as a workaround then?

I'm asking before creating it because issue #351 didn't seem to get any attention from the devs.

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

krodelabestiole commented 4 years ago

+1 that would be great, please don't close, stale bot !

cybergrimes commented 4 years ago

Absolutely would love to see a hide option. For some reason I currently have 3 listings in GFE for Path of Exile, I've hidden two on the PC end but obviously see 3 on my client end. It would be great if we could hide on the Moonlight client side.

Goodix33 commented 4 years ago

+1 it will be nice to have such option in moonlight in order to hide the games we don't want to see

Phiben commented 4 years ago

Are there any updates on this issue? This is a serious UI design flaw.

Chaoclypse commented 4 years ago

I agree, this would be a much appreciated feature.

lyndonguitar commented 3 years ago

Would also like to have this fixed. mainly because I launch my game through the Big Picture app anyway, I have lots of games and it lags my Steam Link(hardware device) when all my scanned games from GFE show up

cgutman commented 3 years ago

It’s already implemented in v2.2.0. Right-click the game to hide it. It’s not accessible via game pad due to a bug that will be fixed in v2.3.0.

lyndonguitar commented 3 years ago

It’s already implemented in v2.2.0. Right-click the game to hide it. It’s not accessible via game pad due to a bug that will be fixed in v2.3.0.

Thanks. I plugged in a mouse on my Steam Link and the option to hide it appeared on right click. Big help!