Closed reloxx13 closed 2 years ago
😮 👍🏻
works, thank you @cgutman .
But the same issue applies for the fullscreen setting. may be important/wanted for headless instances.
Can you elaborate?
Set GUI display mode to fullscreen in settings. Close Moonlight Open Moonlight Moonlight is now in fullscreen mode Select a host Select a game Game starts A new window opens with the stream This window (with the stream) is not fullscreen anymore, it's smaller and not maximized.
Stop the game GUI is correctly back in fullscreen
I'm not sure. If the user wants the stream window to be in full-screen, they can select borderless windowed or full-screen modes.
The maximized GUI and windowed stream case was unique because there's no other way to select a maximized streaming window using the settings. For regular windowed or full-screen GUI settings, those have matching values in the stream display mode settings.
Ahh, right, I did not have the upper dropdown for the stream in mind.
Then the maximized window option is missing in the top dropdown to mirror the behavior of the GUI window.
Generally, I think the stream window should just follow the GUI window. Why should a stream start from a maximized GUI window to get a new small stream window. This case is somehow senseless (and just annoying).
When you open a new window from your internet browser or a new file explorer window, it will have the same size as well, it's just "the standard behavior" users are used to.
You may consider merging those two dropdowns, or why are the two? I think for exclusive fullscreen and borderless fullscreen.
A checkbox would make more sense, cause right now it's unclear which fullscreen mode the fullscreen shortcut (Ctrl+Shift+Alt+x) uses, and it's not configurable.
And, like I did, user don't see or forget there is another dropdown for the stream window and think it is a bug :X
Game window follows main window current state and if main window is fullscreen or stream window is switched to fullscreen by shortcut, get the value from the checkbox and use the user wanted fullscreen mode.
This is just my situation: In most cases I play and do something else on the secondary monitor and I don't want the game to hide my taskbar. So, I play in a maximized window most of the time and only when I play a game full focused I switch to fullscreen and black out the other monitors.
Generally, I think the stream window should just follow the GUI window. Why should a stream start from a maximized GUI window to get a new small stream window.
It doesn't now with the fix in place.
When you open a new window from your internet browser or a new file explorer window, it will have the same size as well, it's just "the standard behavior" users are used to.
Games have historically had a distinction between configuration windows and the game itself, so I don't think the notion of separate GUI and stream preferences is too crazy.
You may consider merging those two dropdowns, or why are the two?
There are some good use cases for having both. For example, I use Moonlight as a remote desktop client to several of my home machines. That means I usually leave it running in the background, so I don't want it stuck in full-screen. However, when I do decide to connect to a machine, I want the stream in borderless windowed mode.
A checkbox would make more sense, cause right now it's unclear which fullscreen mode the fullscreen shortcut (Ctrl+Shift+Alt+x) uses, and it's not configurable.
The current behavior is that you will get borderless windowed if you start in borderless windowed or windowed and full-screen exclusive if you start in full-screen. The logic is if you ask for windowed then decide to toggle to full-screen that you probably intend to multi-task and don't want your displays flashing when switching between Moonlight and other programs.
Long term, full-screen exclusive will go away in favor of borderless windowed everywhere. Borderless windowed is already the default on Wayland and macOS systems. The main reason it's not already gone is because we still use it for DXVA2 on Windows. D3D11VA can provide equivalent performance in borderless and full-screen, except for the refresh rate switching for monitors not running at their optimal refresh rate.
Describe the bug The stream window which opens after choosing a game is not maximized, ignores setting.
For better user feeling, it should follow the main window/gui current window size/config/mode or use the value from the setting.
Steps to reproduce Set
GUI display mode
to maximized in settings. Close Moonlight Open Moonlight Moonlight is now maximized Select a host Select a game Game starts A new window opens with the stream This window is not maximized anymore, it's smaller.Moonlight settings (please complete the following information) Client PC details (please complete the following information) Stream resolution 1080p, client 1080p, host 1080p
Client is a notebook with 2 monitors.
Win10x64,
Moonlight 4.3.0 stable
GF GTX 860M (?)
Server PC details (please complete the following information)
Logfile
```shell 00:00:00 - SDL Info (0): Compiled with SDL 2.24.0 00:00:00 - SDL Info (0): Running with SDL 2.24.0 00:00:00 - Qt Info: No translation available for "en" 00:00:00 - Qt Warning: qrc:/gui/main.qml:12:1: QML ApplicationWindow: ToolTip must be attached to an Item 00:00:01 - Qt Info: Found "gamecontrollerdb.txt" at "C:/Program Files/Moonlight Game Streaming/cache/gamecontrollerdb.txt" 00:00:01 - SDL Info (0): Loaded 465 new gamepad mappings 00:00:01 - SDL Info (0): V-sync disabled 00:00:01 - SDL Info (0): Detected GPU 0: NVIDIA GeForce GTX 860M (10de:1392) 00:00:01 - SDL Error (0): GPU doesn't support HEVC Main10 decoding 00:00:01 - SDL Info (0): Detected GPU 1: Intel(R) HD Graphics 4600 (8086:416) 00:00:01 - SDL Error (0): GPU doesn't support HEVC Main10 decoding 00:00:01 - SDL Info (0): Windowed mode with DWM running 00:00:01 - SDL Info (0): Windowed: 1 | Present Interval: 80000000 00:00:01 - SDL Info (0): Detected WDDM 2.0 or later display driver 00:00:01 - SDL Info (0): Detected GPU: NVIDIA GeForce GTX 860M (10de:1392) 00:00:01 - SDL Info (0): GPU driver: nvldumdx.dll 31.0.15.2647 00:00:01 - SDL Info (0): GPU decoding for format 200 is blocked due to hardware limitations 00:00:01 - SDL Info (0): Detected GPU 0: NVIDIA GeForce GTX 860M (10de:1392) 00:00:01 - SDL Error (0): GPU doesn't support HEVC Main10 decoding 00:00:01 - SDL Info (0): Detected GPU 1: Intel(R) HD Graphics 4600 (8086:416) 00:00:01 - SDL Error (0): GPU doesn't support HEVC Main10 decoding 00:00:01 - SDL Error (0): Unable to load FFmpeg decoder 00:00:01 - SDL Info (0): V-sync disabled 00:00:01 - SDL Info (0): Windowed mode with DWM running 00:00:01 - SDL Info (0): Windowed: 1 | Present Interval: 80000000 00:00:01 - SDL Info (0): Detected WDDM 2.0 or later display driver 00:00:01 - SDL Info (0): Defaulting to D3D11VA for non-FSE mode 00:00:01 - SDL Info (0): Detected GPU 0: NVIDIA GeForce GTX 860M (10de:1392) 00:00:01 - SDL Info (0): GPU decoding for format 100 is blocked due to hardware limitations 00:00:01 - SDL Info (0): Detected GPU 1: Intel(R) HD Graphics 4600 (8086:416) 00:00:01 - SDL Info (0): GPU decoding for format 100 is blocked due to hardware limitations 00:00:01 - SDL Info (0): Windowed mode with DWM running 00:00:01 - SDL Info (0): Windowed: 1 | Present Interval: 80000000 00:00:01 - SDL Info (0): Detected WDDM 2.0 or later display driver 00:00:01 - SDL Info (0): Detected GPU: NVIDIA GeForce GTX 860M (10de:1392) 00:00:01 - SDL Info (0): GPU driver: nvldumdx.dll 31.0.15.2647 00:00:01 - SDL Info (0): GPU decoding for format 100 is blocked due to hardware limitations 00:00:01 - SDL Info (0): Detected GPU 0: NVIDIA GeForce GTX 860M (10de:1392) 00:00:01 - SDL Info (0): GPU decoding for format 100 is blocked due to hardware limitations 00:00:01 - SDL Info (0): Detected GPU 1: Intel(R) HD Graphics 4600 (8086:416) 00:00:01 - SDL Info (0): GPU decoding for format 100 is blocked due to hardware limitations 00:00:01 - SDL Error (0): Unable to load FFmpeg decoder 00:00:01 - SDL Info (0): V-sync disabled 00:00:01 - SDL Info (0): Windowed mode with DWM running 00:00:01 - SDL Info (0): Windowed: 1 | Present Interval: 80000000 00:00:01 - SDL Info (0): Detected WDDM 2.0 or later display driver 00:00:01 - SDL Info (0): Defaulting to D3D11VA for non-FSE mode 00:00:01 - SDL Info (0): Detected GPU 0: NVIDIA GeForce GTX 860M (10de:1392) 00:00:01 - Qt Info: Found "d3d11_vertex.fxc" at ":/data/d3d11_vertex.fxc" 00:00:01 - Qt Info: Found "d3d11_overlay_pixel.fxc" at ":/data/d3d11_overlay_pixel.fxc" 00:00:01 - Qt Info: Found "d3d11_genyuv_pixel.fxc" at ":/data/d3d11_genyuv_pixel.fxc" 00:00:01 - Qt Info: Found "d3d11_bt601lim_pixel.fxc" at ":/data/d3d11_bt601lim_pixel.fxc" 00:00:01 - Qt Info: Found "d3d11_bt2020lim_pixel.fxc" at ":/data/d3d11_bt2020lim_pixel.fxc" 00:00:01 - SDL Info (0): Using D3D11VA accelerated renderer 00:00:01 - FFmpeg: [h264 @ 000001E40D34E900] nal_unit_type: 7(SPS), nal_ref_idc: 3 00:00:01 - FFmpeg: [h264 @ 000001E40D34E900] nal_unit_type: 8(PPS), nal_ref_idc: 3 00:00:01 - FFmpeg: [h264 @ 000001E40D34E900] nal_unit_type: 5(IDR), nal_ref_idc: 3 00:00:01 - FFmpeg: [h264 @ 000001E40D34E900] nal_unit_type: 5(IDR), nal_ref_idc: 3 00:00:01 - FFmpeg: [h264 @ 000001E40D34E900] nal_unit_type: 5(IDR), nal_ref_idc: 3 00:00:01 - FFmpeg: [h264 @ 000001E40D34E900] nal_unit_type: 5(IDR), nal_ref_idc: 3 00:00:01 - FFmpeg: [h264 @ 000001E40D34E900] Format d3d11 chosen by get_format(). 00:00:01 - FFmpeg: [h264 @ 000001E40D34E900] Format d3d11 requires hwaccel initialisation. 00:00:01 - FFmpeg: [h264 @ 000001E40D34E900] Decoder GUIDs reported as supported: 00:00:01 - FFmpeg: [h264 @ 000001E40D34E900] {86695f12-340e-4f04-9fd3-9253dd327460} 103 106 00:00:01 - FFmpeg: [h264 @ 000001E40D34E900] {ee27417f-5e28-4e65-beea-1d26b508adc9} 103 106 00:00:01 - FFmpeg: [h264 @ 000001E40D34E900] {6f3ec719-3735-42cc-8063-65cc3cb36616} 103 106 00:00:01 - FFmpeg: [h264 @ 000001E40D34E900] {1b81bea4-a0c7-11d3-b984-00c04f2e73c5} 103 106 00:00:01 - FFmpeg: [h264 @ 000001E40D34E900] {1b81bea3-a0c7-11d3-b984-00c04f2e73c5} 103 106 00:00:01 - FFmpeg: [h264 @ 000001E40D34E900] {32fcfe3f-de46-4a49-861b-ac71110649d5} 103 106 00:00:01 - FFmpeg: [h264 @ 000001E40D34E900] {d79be8da-0cf1-4c81-b82a-69a4e236f43d} 103 106 00:00:01 - FFmpeg: [h264 @ 000001E40D34E900] {f9aaccbb-c2b6-4cfc-8779-5707b1760552} 103 106 00:00:01 - FFmpeg: [h264 @ 000001E40D34E900] {1b81be68-a0c7-11d3-b984-00c04f2e73c5} 103 106 00:00:01 - FFmpeg: [h264 @ 000001E40D34E900] {5b11d51b-2f4c-4452-bcc3-09f2a1160cc0} 103 106 00:00:01 - FFmpeg: [h264 @ 000001E40D34E900] {efd64d74-c9e8-41d7-a5e9-e9b0e39fa319} 103 106 00:00:01 - FFmpeg: [h264 @ 000001E40D34E900] {ed418a9f-010d-4eda-9ae3-9a65358d8d2e} 103 106 00:00:01 - FFmpeg: [h264 @ 000001E40D34E900] {9947ec6f-689b-11dc-a320-0019dbbc4184} 103 106 00:00:01 - FFmpeg: [h264 @ 000001E40D34E900] {33fcfe41-de46-4a49-861b-ac71110649d5} 103 106 107 00:00:01 - FFmpeg: [h264 @ 000001E40D34E900] {6affd11e-1d96-42b1-a215-93a31f09a53d} 103 106 00:00:01 - FFmpeg: [h264 @ 000001E40D34E900] {914c84a3-4078-4fa9-984c-e2f262cb5c9c} 103 106 00:00:01 - FFmpeg: [h264 @ 000001E40D34E900] Reinit context to 1280x720, pix_fmt: d3d11 00:00:01 - SDL Info (0): FFmpeg-based video decoder chosen 00:00:01 - Qt Info: Found "gamecontrollerdb.txt" at "C:/Program Files/Moonlight Game Streaming/cache/gamecontrollerdb.txt" 00:00:01 - SDL Info (0): Loaded 465 new gamepad mappings 00:00:02 - Qt Debug: Current Moonlight version: "4.3.0" 00:00:02 - Qt Info: Gamepad mappings are up to date 00:00:02 - Qt Info: "ServerName" is now online at "192.168.178.12:47989" 00:00:02 - Qt Info: Latest supported GFE server: "99.99.99.99" 00:00:02 - Qt Debug: Found update manifest match for current platform 00:00:02 - Qt Debug: Latest version of Moonlight for this platform is: "4.3.0" 00:00:02 - Qt Debug: Update manifest version equal to current version 00:00:02 - Qt Info: Discovered mDNS host: "ClientName.local." 00:00:02 - Qt Info: Discovered mDNS host: "ServerNameServer.local." 00:00:02 - Qt Info: "ClientName" is now online at "192.168.178.11:47989" 00:00:02 - Qt Info: Resolved "ClientName.local." to QHostAddress("192.168.178.11") 00:00:02 - Qt Info: Resolved "ClientName.local." to QHostAddress("192.168.178.11") 00:00:02 - Qt Info: Resolved "ServerNameServer.local." to QHostAddress("192.168.178.12") 00:00:02 - Qt Info: Resolved "ServerNameServer.local." to QHostAddress("fe80::aaf6:1a5a:d9e7:7b4e") 00:00:02 - Qt Info: Resolved "ClientName.local." to QHostAddress("::1") 00:00:04 - Qt Info: Processing new PC at "192.168.178.11:47989" from mDNS with IPv6 address "[::1]:47989" 00:00:04 - Qt Info: Processing new PC at "192.168.178.12:47989" from mDNS with IPv6 address "Not important, but still a bug. Im just happy that fullscreen/maximize/normal change is working correctly now.