search

moonpyk / mvcdonutcaching

ASP.NET MVC Extensible Donut Caching brings donut caching to ASP.NET MVC 3 and later. The code allows you to cache all of your page apart from one or more Html.Actions which can be executed every request. Perfect for user specific content.
https://github.com/moonpyk/mvcdonutcaching
MIT License
142 stars 49 forks source link

Childactions can contain donuts #7

Closed mlidbom closed 11 years ago

mlidbom commented 11 years ago

We have been scratching our heads trying to get the cache to work with no success until I actually dug into the code. Maybe I'm missing something, but as far as I can tell things are utterly broken when donuts contain donuts. This change makes everything work sanely for us according to my testing so far.

moonpyk commented 11 years ago

Yup this is strange, presented like this I don't see any reason for donuts to not contain donuts.

mlidbom commented 11 years ago

That's a relief.

I was a bit worried that I might have been missing some fundamental part of the design/intended use.

Do you have any idea when a NuGet package with this fixed might be available? I prefer not to repackage dependencies unless I have to. Sorry to bug you like this, but if it will be a while I'd better get cracking on repackaging it for our private NuGet feed. A pre-release would be greatly appreciated if you feel that it is not ready for prime time.

moonpyk commented 11 years ago

I'm gonna make a prerelease tonight, you took time to make a well documented commit, I can take 5 minutes to push a 1.3.0 beta1 on nuget :)

mlidbom commented 11 years ago

Great. Thanks a lot :)

moonpyk commented 11 years ago

prerelease is available on nuget, i'll reauthor the second commit you made in the test project now. This is a downside of a separated subproject...

mlidbom commented 11 years ago

Yea. That's actually why I did not base this on the latest version of master. I did not have the time to manage multiple pull requests.

Thanks again for the release. Really helps me out :)

moonpyk commented 11 years ago

Thanks to you :)