At https://github.com/moonpyk/ncuid/blob/master/NCuid/Cuid.cs#L104, you create a new instance of Random every time the method is called. If I call it in a loop very quickly, then that part of the cuid won't be truly random, as C♯ / .NET seeds Random with the system's clock.
Consider making Random a private static member of the class itself.
moonpyk
commented
6 years ago
At https://github.com/moonpyk/ncuid/blob/master/NCuid/Cuid.cs#L104, you create a new instance of
Randomevery time the method is called. If I call it in a loop very quickly, then that part of the cuid won't be truly random, as C♯ / .NET seedsRandomwith the system's clock.Consider making
Randoma private static member of the class itself.