search

moonrepo / starbase

Framework for building performant command line applications and developer tools.
MIT License
68 stars 6 forks source link

new: add murex shell support #83

Closed abhishek818 closed 1 week ago

abhishek818 commented 1 week ago

fixes #82 /claim #82

abhishek818 commented 1 week ago

Up for review @milesj

milesj commented 1 week ago

@abhishek818 Can you rebase master. Some of this method names changed, and new ones were added.

As for the new hook event, you can do something similar to direnv: https://github.com/direnv/direnv/blob/master/internal/cmd/shell_murex.go#L12

abhishek818 commented 1 week ago

@milesj I have addressed your comments.

milesj commented 1 week ago

/approve

algora-pbc[bot] commented 1 week ago

@milesj: The claim has been successfully added to reward-all. You can visit your dashboard to complete the payment.

milesj commented 1 week ago

Thanks for the work!

abhishek818 commented 1 week ago

@milesj: The claim has been successfully added to reward-all. You can visit your dashboard to complete the payment.

@milesj hey, seems bounty payment is not done. Ideally it should tag contributor's username and send a email notification also. Can you check this

milesj commented 1 week ago

Ok manually did it in the console, should be good now.

abhishek818 commented 1 week ago

@milesj yup, that worked thanks.