feat: support shell value quoting

[varshith257]

fixes #81 /claim #81

Here are the docs I have used as a reference for adding quoting rules:

• [x] Bash: https://www.gnu.org/software/bash/manual/html_node/Quoting.html#:~:text=Quoting%20can%20be%20used%20to,it%20is%20to%20represent%20itself.
• [x] Elvish : https://elv.sh/ref/language.html
• [x] Fish: Reference link
• [x] Ion: https://doc.redox-os.org/ion-manual/general.html
• [x] Murex: https://murex.rocks/tour.html#basic-syntax
• [x] PowerShell: Reference Link
• [x] Sh : https://rg1-teaching.mpi-inf.mpg.de/unixffb-ss98/quoting-guide.html#:~:text=Bourne%20shell%20uses%20three%20characters,function%20in%20the%20shell%20syntax.
• [x] Xonsh: https://xon.sh/tutorial_subproc_strings.html
• [x] Zsh: https://info2html.sourceforge.net/cgi-bin/info2html-demo/info2html?(zsh)Quoting#:~:text='%5C'%20followed%20by%20a%20newline,the%20'%5C''%20escape.
• [x] Nu: https://www.nushell.sh/book/working_with_strings.html

[varshith257]

@milesj I have added escaping/quoting rules for the info I have researched for the respective shells.

It will be great to review them. If any suggestions or modifications are needed, I will incorporate them as needed :)

[varshith257]

IMO, for the format_env_unset and format_path_setmethods, the quote method is not directly needed because these methods are typically used for operations where quoting is not necessary or it is handled implicitly by the shell environment.

[varshith257]

@milesj Can you chime in for review?

[milesj]

@varshith257 I'll be out most of the weekend, but in the mean time, could you link all the docs you used as references, and add some tests cases. When I'm back, I'll review it.

[varshith257]

Sure

[varshith257]

@milesj Hope you consider my work and my last 3 days' efforts on research and made this progress except for the small fixes left. I am more interested in working on this issue and to gain exposure and experience with the various shells.

I have incorporated the most shell-specific quoting rules to each shell and left unquoted paths and I am not sure paths needed quoting. If needed, I will incorporate them. Please review and if any changes are needed I am quick here to implement and complete this issue.

[varshith257]

@milesj I have added the reviewed suggestions and also fixed the failing tests

[varshith257]

@milesj Any comments on my replies to the reviews? Let's quickly wrap it up and complete this :)

[varshith257]

And the tests are failing due to snapshots missing of Nu shell from macOS and Ubuntu. I have done this work in Windows. I think we need to run tests on Ubuntu and macOs to generate respective snapshots which is causing test fails

[varshith257]

@milesj I have removed the quote method in unset methods wherever not needed.

[milesj]

Look into fixing the lints, and I'll fix the snapshots.

[varshith257]

@milesj Lints also the same of failed for snapshots will get it resolved once it generates snapshots for Nu shell of Ubuntu and macOS

[milesj]

Can you fix the warnings?

[varshith257]

There are 30+ warnings emitted could be another effort to reiterate and test them, but I will fix the warnings too to make our codebase clean and improve code quality

[varshith257]

@milesj I have fixed all the lint warnings emitted and ensured all tests passed

The snapshots generation are only left for now :)

[milesj]

/approve

[algora-pbc[bot]]

@milesj: The claim has been successfully added to reward-all. You can visit your dashboard to complete the payment.

[milesj]

Thanks for this, much appreciated.

I'll merge through the error and fix on master.

[milesj]

/tip $100 @varshith257

Thanks for all the work! There will definitely be more in the future.

[algora-pbc[bot]]

👉 @milesj: Navigate to your dashboard to proceed

[algora-pbc[bot]]

🎉🎈 @varshith257 has been awarded $100! 🎈🎊

• Share on socials
• Give feedback