moonrepo / starbase

Framework for building performant command line applications and developer tools.
MIT License
68 stars 6 forks source link

feat: implement escaping/quoting rules for shell (#81) #86

Closed abhishek818 closed 5 days ago

abhishek818 commented 5 days ago

changes done for bash based shells first several todos left

fixes #81 /claim #81

abhishek818 commented 5 days ago

@milesj tagging you just for a heads up. If you like this current work, perhaps assign me this issue since this is a good enough big feature (not that much , but still), Anyways will continue my work on this..

varshith257 commented 5 days ago

@abhishek818 I wanted to touch base regarding the work we're both tackling. I've been heavily invested in resolving the issues and making progress. I'm more interested to complete this work and actively engaged in resolving the issues and making progress. I kindly request that you hold off on proceeding with this particular task until I've had a chance to complete my attempt. If for any reason I decide not to continue, I'll let you know, and you're welcome to take it forward.

I think it results in duplicate of efforts. Hope you consider it @abhishek818

abhishek818 commented 5 days ago

@varshith257 bro but mine is totally a different implementation here. And I believe there are always two types of repos : 1. Where a person is assigned a issue first to let only that person complete or abondon it.

  1. Where anyone interested can take a chance and first complete working PR makes it.

I was also working on this issue since first day but never commented 'attempt' as I wanted to have a working implementation first.

Would have really abondoned this but I see my current work done till now as more better approach for this..

CC: @milesj ..

varshith257 commented 5 days ago

Where anyone interested can take a chance and first complete working PR makes it.

As you stated, I have done some progress to all shells quoting methods and reiterating to be align with issue requirements and Shell specific quoting methods.

I agree with it and I am already have done some progress and let me have a chance to complete this attempt. If I will give up on this and let you know this and I am ensuring of no duplicate efforts of us towards it :)

milesj commented 5 days ago

Will be going with the other PR: https://github.com/moonrepo/starbase/pull/84

Nothing wrong with this PR at all, I just had to pick one :P

Here's a tip for the work so far.

milesj commented 5 days ago

/tip $150 @abhishek818

algora-pbc[bot] commented 5 days ago

👉 @milesj: Navigate to your dashboard to proceed

algora-pbc[bot] commented 5 days ago

🎉🎈 @abhishek818 has been awarded $150! 🎈🎊

abhishek818 commented 4 days ago

Thanks @milesj for the tip. @varshith257 best of luck to you but also have a look at this pr changes to pick anything you find better.