moonshot-nagayama-pj / PnPQ

Python package for Controlling Optical Devices in Quantum Testbed
Other
0 stars 0 forks source link

Stub Mode for Optical Switch #21

Closed zigen closed 3 months ago

zigen commented 6 months ago

In order to aid future integration testing and help learn more about how our hardware works, we are building "stub" versions of devices. These do not connect to real hardware, but instead mimic or mock the behavior of those devices in code.

Later on, this will help us define common interfaces for devices, instead of the device-specific interfaces that we have now. It may also help us find better ways to refactor our existing code.

Acceptance criteria

auspicacious commented 3 months ago

@master-of-ppap Welcome to Thunderdome. I suggest looking at https://github.com/moonshot-nagayama-pj/PnPQ/pull/23 for an idea of what the final product will look like.

@TomShen1234 Did I miss anything in the acceptance criteria? I am planning on writing a more general "definition of done" in the future.

TomShen1234 commented 3 months ago

Looks fine to me right now.

master-of-ppap commented 3 months ago

@master-of-ppap Welcome to Thunderdome. I suggest looking at #23 for an idea of what the final product will look like.

Thank you! Is there any documentation for what the optical switch does/is supposed to do?

auspicacious commented 3 months ago

Is there any documentation for what the optical switch does/is supposed to do?

@hhatpsi and @Marie2222 would be good people to ask about that.

auspicacious commented 3 months ago

Initial stub is done, so I'm marking this as done. After refactoring in https://github.com/moonshot-nagayama-pj/PnPQ/issues/27 we will have more work to do here.