Closed zigen closed 3 months ago
@master-of-ppap Welcome to Thunderdome. I suggest looking at https://github.com/moonshot-nagayama-pj/PnPQ/pull/23 for an idea of what the final product will look like.
@TomShen1234 Did I miss anything in the acceptance criteria? I am planning on writing a more general "definition of done" in the future.
Looks fine to me right now.
@master-of-ppap Welcome to Thunderdome. I suggest looking at #23 for an idea of what the final product will look like.
Thank you! Is there any documentation for what the optical switch does/is supposed to do?
Is there any documentation for what the optical switch does/is supposed to do?
@hhatpsi and @Marie2222 would be good people to ask about that.
Initial stub is done, so I'm marking this as done. After refactoring in https://github.com/moonshot-nagayama-pj/PnPQ/issues/27 we will have more work to do here.
In order to aid future integration testing and help learn more about how our hardware works, we are building "stub" versions of devices. These do not connect to real hardware, but instead mimic or mock the behavior of those devices in code.
Later on, this will help us define common interfaces for devices, instead of the device-specific interfaces that we have now. It may also help us find better ways to refactor our existing code.
Acceptance criteria
pytest
unit tests are written for all public methods, with meaningful inputs