search

moonshotcollective / pay.party

pay-party.vercel.app
MIT License
9 stars 18 forks source link

Top Banner displayed 'You must switch to Mainnet' but I needed to be on Rinkeby #185

Closed ufkhan97 closed 2 years ago

ufkhan97 commented 2 years ago

Describe the bug Top Banner displayed 'You must switch to Mainnet' but I needed to be on Rinkeby

To Reproduce Steps to reproduce the behavior:

  1. Go to a pay party created on Rinkeby
  2. Be on Mainnet in wallet and app
  3. Use 'You Must Switch Network To Vote' button to switch to Rinkeby from mainnet in wallet
  4. See Top Banner displays 'You have Rinkeby selected and you need to be on Mainnet'

Expected behavior Top Banner should say 'You have Mainnet selected (in app) and need to be on Rinkeby'

Screenshots

Screen Shot 2022-04-12 at 1 05 58 PM

Desktop (please complete the following information):

Additional context Add any other context about the problem here.

gtcsameer commented 2 years ago

Thanks for this issue Umar! Just curious, how is this different from #184; personally, I think these two issues seem to be related to the same bug. Are you just splitting both parts of the bug into two separate issues?

ufkhan97 commented 2 years ago

I think they're two different bugs but both related to network issues. One is about the mid-screen network switch banner which doesnt switch your network. The other is about the top-screen banner that does not correctly detect the network you're in.

On Wed, Apr 13, 2022, 12:48 PM gtcsameer @.***> wrote:

Thanks for this issue Umar! Just curious, how is this different from #184 https://github.com/moonshotcollective/pay.party/issues/184; personally, I think these two issues seem to be related to the same bug. Are you just splitting both parts of the bug into two separate issues?

— Reply to this email directly, view it on GitHub https://github.com/moonshotcollective/pay.party/issues/185#issuecomment-1098270877, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKO2NIWLVMXB63UE75T3SGDVE33EFANCNFSM5TIBC6YA . You are receiving this because you authored the thread.Message ID: @.***>

blahkheart commented 2 years ago

I took a moment to inspect the bug and what happens is, after clicking the switch network button on the app it switches your network in your wallet to the specified network but it doesn't switch the network of the app to the same network, it remains on the current network, thus causing the new error displayed by the top banner which in this particular case is "You have rinkeby selected and you need to be on Mainnet".