moonshotcollective / pay.party

pay-party.vercel.app
MIT License
9 stars 18 forks source link

No Check For Invalid Voter & Candidate Input #188

Closed gtcsameer closed 2 years ago

gtcsameer commented 2 years ago

Describe the bug

If the user is creating a party and inputs an invalid input (anything that is not a valid wallet address or not a valid ENS), the user can still continue to create the party and the party would populate the invalid input as null.

To Reproduce Steps to reproduce the behavior:

  1. Begin the process of creating a pay party
  2. Under either Voter or Candidate (or both), input an invalid wallet address or invalid ENS address (you can input any gibberish)
  3. Although the tile turns red to symbolize an invalid input, the user can still continue the process and create a party all the way through.
  4. Create the party and see blank, null tiles in the place where the invalid inputted wallet address will be.

Expected behavior

  1. Begin the process of creating a pay party2.
  2. Under either Voter or Candidate, if an invalid wallet address or invalid ENS address is inputted, the tile should continue to highlight it as red
  3. however, the user should not be able to press Continue until all errors are resolved. The Continue Button should be grayed out until errors are resolved
  4. Create the party and see only valid inputs in the final party voting screen

Screenshots: Invalid input, but still able to press Continue button

Screen Shot 2022-04-19 at 6 16 49 PM

Confirming a party with an invalid input. Notice how it populates as null in the signature request.

Screen Shot 2022-04-19 at 6 17 11 PM

Final Vote Screen showing a null user to be voted on.

Screen Shot 2022-04-19 at 6 18 22 PM