transactions are back to making memos on all tx

lastmeta commented 2 years ago

Describe The Bug

https://rvnt.cryptoscope.io/tx/?txid=6a38385cf71ef871e9f70b572221b47a0290792a3deb8587fe4e657ba7da9897 nulldata is a blank memo.

this was fixed at one point

To Reproduce

make a transaction

Expected Behavior

if you don't fill out memo, it doens't add it.

lastmeta commented 2 years ago

saw this happen again on https://rvnt.cryptoscope.io/tx/?txid=d8e5aa8ffaec83c1a38c5ea3fcf4afa953142e5126abc682aece066e2778cfde

it's really the assetMemo that is the problem, not the op return memo, just called memo.

notice this send request shwos an assetMemo as null, and the memo as null for that matter. And everywhere down the line it shows as null.

I/flutter ( 6823): SEND REQUEST SendRequest(sendAll: true, sendAddress: mhFCxDPT1z5LZWsLr9AwJDpRA5DGFifLTv, holding: 1000003.0, visibleAmount: 1000003.0, sendAmountAsSats: 100000300000000, feeGoal: Instance of 'TxGoal', wallet: LeaderWallet(03d992f22d9e178a4de02e99ffffe885bd5135e65d183200da3b566502eca79342, 18aff5c78bcb068d804e20c240394b16, {CipherType: None, PasswordId: null}, false), security: Security(symbol: MOONTREE, securityType: SecurityType.RavenAsset), assetMemo: ?, memo: ?, note: ?)
I/flutter ( 6823): sendRequest.assetMemo: null
I/flutter ( 6823): sendRequest.assetMemo?.base58Decode: null
I/flutter ( 6823): ipfsData: null
I/chatty  ( 6823): uid=10154(com.moontree.ravenmobile) 1.ui identical 1 line
I/flutter ( 6823): ipfsData: null

I've confirmed it does not get into this if statement, because it's null:

  if (ipfsData != null) {
    internal_builder.add(ipfsData);
  }

so I suspect something else is causing this deep in the ravenwallet code or something

lastmeta commented 2 years ago

I sent two transactions, one with a memo and one without, the one with an op return memo, also included an asset memo:

https://rvnt.cryptoscope.io/tx/?txid=794fa3eee7ebb0fabebab88029745b6af9762de9573a987b3247ab783f6a6b6c https://rvnt.cryptoscope.io/tx/?txid=0dbd6f2dd4bcc947103f3850bfc15dadd6affe76c082db7b5d987992922d43c7

So I think if .addMemo is called it somehow modifies the tx to add nulldata as an assetMemo? maybe?

lastmeta commented 2 years ago

this one is fixed

moontreeapp / moontree