moonwell-fi / moonwell-contracts-v2

BSD 3-Clause "New" or "Revised" License

18 stars 12 forks source link

Refactor: Use strings for emission token #329

Closed ElliotFriedman closed 1 month ago

ElliotFriedman commented 1 month ago

Refactor rewards configurations to use string that represents emission token instead of using the address itself. This lends itself to greater readability for proposals.

add isAddressContract check to reward speed proposals for emission token
add isAddressSet check to reward speed proposals for emission token

openzeppelin-code[bot] commented 1 month ago

Refactor: Use strings for emission token

Generated at commit: 3b65f91172d9f7f764633edb3587e0edff0e7ba3

🚨 Report Summary

Severity Level Results

Contracts Critical
High
Medium
Low
Note
Total 3
2
0
15
44
64

Dependencies Critical
High
Medium
Low
Note
Total 0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

	Severity Level	Results
Contracts	Critical High Medium Low Note Total	3 2 0 15 44 64
Dependencies	Critical High Medium Low Note Total	0 0 0 0 0 0

ElliotFriedman commented 1 month ago

Implement fix for https://github.com/moonwell-fi/moonwell-contracts-v2/issues/309.

github-actions[bot] commented 1 month ago

Rewards Distribution Proposal :

Proposal  failed. Check CI logs

github-actions[bot] commented 1 month ago

Latest Proposal: src/proposals/mips/mip-b25/mip-b25.sol

Proposal src/proposals/mips/mip-b25/mip-b25.sol failed. Check CI logs