Forge only supports up to 17 decimals precision

moonwell-fi / moonwell-reward-automation

0 stars 0 forks source link

Open anajuliabit opened 2 months ago

anajuliabit commented 2 months ago

Foundry parseJson has a limitation of 17 decimal places

So for example if the json contains the following value:

106202375773511586508800e23

foundry will give us this value as the output from the json

106202375773511580000000e23

as we can see it eats the last 8 digits, therefore the wei amounts in the jsons should have a maximum of 17 decimal places

lyoungblood commented 1 month ago

@anajuliabit what do you propose we do about this?

anajuliabit commented 1 month ago

@lyoungblood I believe we should do the following:

For internal transfers (e.g., transferring from Moonbeam to the Temporal Governor), we should round up to ensure there's always enough for the proposal on the external chain, even if a small dust amount remains in the Temporal Governor.
When transferring from the Temporal Governor to the MRD, etc., we should round down so that the Temporal Governor always has sufficient funds to make all transfers.

lyoungblood commented 1 month ago

Ok, thanks, I took care of this in #35