moorepants / BicycleParameters

Calculates the geometry, masses, centers of mass, and the moments of inertia of the bicycle rider system.
https://bicycleparameters.readthedocs.io
Other
38 stars 20 forks source link

Initial thoughts on the UI design #39

Closed moorepants closed 4 years ago

moorepants commented 4 years ago

@sandertyu You probably have some or all of these already in your head, but here are my initial thoughts:

sandertyu commented 4 years ago

Okay, all of this is possible. I have a few questions though.

  1. What do you mean by "left-right centered", with regards to the figures and table? Do you mean within the context of the entire page?

  2. I can swap the order of the eigen and geometry plots back to how they were. I switched them because I've locally been working on a CSS layout which has the table on the left hand side, and the plots one on top of the other on the right hand side. If you would prefer that it just work vertically from figures to table rather than being in separate columns, I can revert to that.

  3. The application does not work properly for me at all. I have my master branch exactly up to date with yours, and yet when I run it (via the py -m bicycleparameters.cycle_app method that we have discussed), the plots are simply all wrong. I went into this more in detail in my replies to your email regarding my 4/16 AIO. This wouldn't be an issue per se, because it works so well on the online website, but I simply cannot debug with it working like this. I have attached a couple images of what this looks like for me. benchmark crescendo

moorepants commented 4 years ago

Do you mean within the context of the entire page?

Yes, on a wide screen they hug the left side of the page.

I switched them because I've locally been working on a CSS layout which has the table on the left hand side, and the plots one on top of the other on the right hand side.

That sounds good. The best way to go about this is to make some sketches or mockups of what you want the layout to look like. Then we can give feedback based on that before you spend a lot of time coding it. There are even fancy ways to do this, e.g. https://moqups.com/, but a sketch with pencil on paper is sufficient.

The application does not work properly for me at all.

Weird. You should clone the repository in a separate directory and see if you can run it from there. If you can, that means that something is buggered in you main directory you've been working on.

moorepants commented 4 years ago

The background didn't load one time for me and I got this: image

I think it looks better with solid background. The halloween color theme can look really good with a black background. I actually may delete the image background in skijumpdesign eventually. It's hard to get it working good in terms of font colors and provide a good visual aesthetic.

AndrewDressel commented 4 years ago

Looks fantastic!

moorepants commented 4 years ago

Thank @AndrewDressel ! I'll comment on a few of them.

Are you planning to indicate size and orientation of principal moments of inertia on the bike schematic diagram?

There is a light colored inertia ellipse for each body, but we can eventually swap to these:

image

Are you considering a way for users to enter front assembly inertia components relative to steering axis?

We can do this. Maybe a check box would swap the table entries for inertia aligned with steer axis.

The first time I selected a new bike, it took a while to draw the new graphs, and I didn't know if I needed to click on some additional control. Consider displaying some kind of indication that work is in progress.

@sandertyu dash has a feature to change the mouse curse to a waiting icon or you can grey the screen while it calculates.

These things can be sped up too. Right now things aren't optimized in any way.

It seems with my color scheme that one of the real weave lines is sometimes mistaken for capsize with the benchmark bicycle.

The algorithm isn't full proof. I could do some work to improve. I wrote that a decade ago now!

Do you plan to provide some way for users to save, import, or export their own named bikes?

Yes, that is definitely something we want to support.

Will you implement some kind of "About" or "Help" functionality in the UI?

Yes, I think this might be the next major task.

The schematic of some bikes include an ellipse around the "H" center of mass. What does it indicate?

That's the inertia ellipse.

All other feedback is very helpful. We'll get them taken care of as we iterate.

moorepants commented 4 years ago

Oh yeah, on the name JBike7. Do you want it named that? If so, I can ping Andy and others.

moorepants commented 4 years ago

Is JBike Jim-Bike?

AndrewDressel commented 4 years ago

That is my understanding, yes.

Andrew Dressel, PhD Depts of Civil & Mech Eng University of Wisconsin-Milwaukee


From: Jason K. Moore notifications@github.com Sent: Tuesday, April 21, 2020 9:33:19 AM To: moorepants/BicycleParameters BicycleParameters@noreply.github.com Cc: AndrewDressel AndrewDressel@hotmail.com; Mention mention@noreply.github.com Subject: Re: [moorepants/BicycleParameters] Initial thoughts on the UI design (#39)

Is JBike Jim-Bike?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmoorepants%2FBicycleParameters%2Fissues%2F39%23issuecomment-617218295&data=02%7C01%7C%7C97761032f8654601d41108d7e600f073%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637230764006796780&sdata=ius8EWB8n6d%2BMZSxIrDaXe%2F%2FPmaZldgqQ4Q%2Bi2nyFr4%3D&reserved=0, or unsubscribehttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAPIZNOQM6ZJ77KFZGPNCJVLRNWVC7ANCNFSM4MKZ7SFA&data=02%7C01%7C%7C97761032f8654601d41108d7e600f073%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637230764006806774&sdata=Xb0bQU3s70VLA4iXBclQ9TCAw%2BTatv9aG5lUW80EGLI%3D&reserved=0.

AndrewDressel commented 4 years ago

That would be the next version in the series, yes, and sure, please also check with the others.

Andrew Dressel, PhD Depts of Civil & Mech Eng University of Wisconsin-Milwaukee


From: Jason K. Moore notifications@github.com Sent: Tuesday, April 21, 2020 9:32:57 AM To: moorepants/BicycleParameters BicycleParameters@noreply.github.com Cc: AndrewDressel AndrewDressel@hotmail.com; Mention mention@noreply.github.com Subject: Re: [moorepants/BicycleParameters] Initial thoughts on the UI design (#39)

Oh yeah, on the name JBike7. Do you want it named that? If so, I can ping Andy and others.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://nam03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmoorepants%2FBicycleParameters%2Fissues%2F39%23issuecomment-617218043&data=02%7C01%7C%7C476a6ec58a6c4f799f3508d7e600e2d9%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637230763779614855&sdata=y7Z0S4xjn5vmW4mnoTFIAZSkOIuqkVSUaqEFqGKVA2g%3D&reserved=0, or unsubscribehttps://nam03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAPIZNOTEDVX7O7ZUGWJ5OE3RNWVBTANCNFSM4MKZ7SFA&data=02%7C01%7C%7C476a6ec58a6c4f799f3508d7e600e2d9%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637230763779624863&sdata=rhAHZz0fSbgS6ymna5WplGf78lWPuULKzBFmK15VjAE%3D&reserved=0.

moorepants commented 4 years ago

We've resolved a fair number of these. See the current app version at:

https://bicycleparameters.herokuapp.com/

I've opened new separate issues for remaining things to fix and improve. Closing this.