search

moorepants / BicycleParameters

Calculates the geometry, masses, centers of mass, and the moments of inertia of the bicycle rider system.
https://bicycleparameters.readthedocs.io
Other
38 stars 20 forks source link

change the background color to white when selected #81

Closed rrryy39 closed 3 years ago

rrryy39 commented 3 years ago

selected

moorepants commented 3 years ago

You're first pull request! Nice!

moorepants commented 3 years ago

I just ran this on my computer and see one issue. If I click cells in the first column of any table the text does not change to black with the white background: image

Either make those cells not-clickable or make them behave like your cells.

Make your changes, commit again, and push the branch. That will update this PR with new commits.

rrryy39 commented 3 years ago

I changed the background color to gray and text color to black, if you do not like the theme, i can try to make the cell unclickable image

moorepants commented 3 years ago

I don't think that looks good. I liked what you had first, but you need to have all columns behave the same.

rrryy39 commented 3 years ago

Now the first column's text is black when the cell is selected image

moorepants commented 3 years ago

Good. This works for me.

moorepants commented 3 years ago

Remove the old commented code and I'll merge this.

rrryy39 commented 3 years ago

comments removed

moorepants commented 3 years ago

Great your first PR is in! On to the next :)