search

moorepants / BicycleParameters

Calculates the geometry, masses, centers of mass, and the moments of inertia of the bicycle rider system.
https://bicycleparameters.readthedocs.io
Other
38 stars 20 forks source link

Model() should take a ParameterSet() instead of a dictionary as it's primary object #87

Closed moorepants closed 1 year ago

moorepants commented 2 years ago

RIght now Model() takes a dictionary but that means you can't use any functionality of ParameterSet() inside of Model().

moorepants commented 2 years ago

Actually it does! But the docstring is incorrect.

moorepants commented 1 year ago

After using Model() for some time, none of the features of ParameterSet() are used in Model() so maybe it should only take a dictionary. Although, I guess if you had a parameter set for one model it could call the appropriate method to transform the data into the parameter set of a new model internally.

moorepants commented 1 year ago

It takes a parameter set.