search

moorepants / BicycleParameters

Calculates the geometry, masses, centers of mass, and the moments of inertia of the bicycle rider system.
https://bicycleparameters.readthedocs.io
Other
38 stars 20 forks source link

Plotly is not in the requirements #99

Closed tjstienstra closed 5 months ago

tjstienstra commented 1 year ago

When installing the development version of this repo, I noticed that plotly is currently not in the requirements, while it is being used.

tjstienstra commented 1 year ago

It is possible that one should also add pandas to the requirements. plotly seems to require it, but does not install it automatically?

I got the following error: ImportError: Plotly express requires pandas to be installed.

moorepants commented 1 year ago

pandas and plotly should be optional dependencies only needed for the app to run.

tjstienstra commented 1 year ago

import plotly.express as px is in main.py, so you kind of always need it now. It is used in _plot_bicycle_geometry_plotly and _plot_eigenvalues_vs_speed_plotly

moorepants commented 1 year ago

That needs to be moved out to another file.

moorepants commented 1 year ago

Fix proposed in #100.