Feature/frontend/theme/overhaul

[danpolanco]

I still have some minor changes I want to make. I also would like your opinion on resources/templates/frames. I made that folder as I was going along to keep what I was working on separate and easy to debug.

Let me know what you think!

Todo:

• [x] Fix login screen text (it's invisible in firefox and partially in safari)
• [x] Remove account information from top bar
• [x] test all functions on live server to make sure I didn't break anything
• [x] clean up code (since I'm new to angular, css, html)
• [x] rebase all changes into one nice commit?

[itzg]

I pulled down your branch and ran it...great job! I only found two visual things I'd like you to address:

I haven't looked at the code yet, so let me know if you want me to wait until you knock out your cleanup TODOs first. Or I can look before then and give you advice, if you want.

[danpolanco]

Please take a look :) cuz I dunno where to start.

Sent from my mobile so sorry for the being curt!

On Jan 15, 2016, at 17:19, Geoff Bourne notifications@github.com wrote:

I pulled down your branch and ran it...great job! I only found two visual things I'd like you to address:

I haven't looked at the code yet, so let me know if you want me to wait until you knock out your cleanup TODOs first. Or I can look before then and give you advice, if you want.

— Reply to this email directly or view it on GitHub.

[itzg]

Sorry for all the comments. This turned out to be a good conduit to voice some contributor guidelines that were in my head.

[danpolanco]

No worries. Now time for me to fix all of them :dash:

[itzg]

I just noticed "Status" needs space after the label:

Also, I tried out the interface on my iPhone and it's a lot more usable than it was before; however, it seems to take a few taps on "Create Container" to go there and even then the sidebar doesn't slide back automatically. I haven't investigated any yet to see if the click is too small or what. It's also a pain since Chrome on my iPhone doesn't show if there's any JS errors occurring. For what it's worth here's a screen grab:

[danpolanco]

Thanks for testing it out!

FYI not related to the above convo, there are more style changes I want to make that I'm leaving alone until after a successful pull request. For example:

the white border will either go away, or change to look more natural. Stuff like that.

[itzg]

Sounds like a good plan.

[danpolanco]

I haven't had a chance to fix the touch / sidebar slide back yet, but the rest of the issues are pretty well done.

[danpolanco]

I looked and I'm not sure about the touch / sidebar slide back on mobile issue. Hopefully it'll become apparent as I keep working with the theme.

Otherwise, I think this puppy is ready to go. Since it hasn't been merged yet, I'm going to continue to work on it. I don't really want to, but I think it's time to go through all the css and figure out what is actually needed. Right now, it's a mess :disappointed:

[danpolanco]

Cancel that. It's actually ok for now.

[itzg]

Since that file is focused on the theme, then it's okay to leave all that in there. Being cascading we can then include a style sheet after the theme for specific tweaks.

Now, if there's any modifications you had to make, then put back the original theme css and then move your mods to the new cascaded style sheet.

[danpolanco]

Cool. The only changes I made were just bugs (e.g. width: 90px and width: 100% both present).

[danpolanco]

Whoops! Broke the login page. Gotta figure out where I did that.

[danpolanco]

Very weird. I have firefox on private browsing so it should start fresh. When I first click the login button it goes to this:

If I press the back button and click login again, it goes to the correct page...

[itzg]

To baseline weird redirect scenarios like that, enter http://localhost:8080/ in the address bar and press Enter/Return to confirm you're starting from that known point.

[danpolanco]

No dice :-/ I'm not sure what's up.

[danpolanco]

Huh. Nvm. When I remove:

<!--suppress HtmlUnknownTarget -->
<script type="text/javascript" src="vendors/tui2tone/navbar.js"></script>

From the ext-js.ftl, it works right.

[danpolanco]

So I guess remove tui2tone/navbar.js and replace its function with something from ngmodules.org?

[itzg]

No that's fine to stick with tui2tone for the navbar. Since there's not a lot of Angular going on there, it's not a problem.

[itzg]

@DanTheColoradan , where do you stand on this now? I'm happy with all the changes now, but wanted to wait to merge until I got a green light from you.

[danpolanco]

You have the green light!

I'm not entirely satisfied because I want to get rid of the last bit of js from the theme. I can do that separately though.

Let me know if you need any other final changes / reversions.

On Jan 18, 2016, at 21:20, Geoff Bourne notifications@github.com wrote:

@DanTheColoradan , where do you stand on this now? I'm happy with all the changes now, but wanted to wait to merge until I got a green light from you.

— Reply to this email directly or view it on GitHub.

[itzg]

Check it out @DanTheColoradan , your changes are live!

https://mccy.itzg.me

[danpolanco]

Woot :D thx for the update!

———— Daniel L. Polanco Fledgling Programmer | Perl | C++ 719-422-3765 | Website | GitHub | Twitter | Safe Email ————

On Jan 19, 2016, at 20:36, Geoff Bourne notifications@github.com wrote:

Check it out @DanTheColoradan , your changes are live!

https://mccy.itzg.me

— Reply to this email directly or view it on GitHub.

[sshipway]

I like the look of the new frontend... the mod upload (once it works :)) is much better with a progress meter.

[itzg]

I'm liking the new look a whole lot better. There always was a progress bar there...but since it's failing now you can see it :)