search

moorkop / mccy-engine

Provides a web based "Minecraft Server as a Service" (MCaaS?) to deploy Minecraft server containers on any Docker Swarm cluster or standalone Engine instance.
Apache License 2.0
12 stars 4 forks source link

Feature/frontend/mods/dropdown #68

Closed danpolanco closed 8 years ago

danpolanco commented 8 years ago

Double check this for me?

Seems fragile because (a) I'm reusing code via copy and paste and (b) I removed if (_.includes(cModdedTypes, newValue)). I believe it works though!

Closes #18.

itzg commented 8 years ago

...as for if (_.includes(cModdedTypes, newValue)), that was needed in the "new container" controller since it needed to decide between using the full, vanilla list of versions or asking the backend what versions apply to the currently chosen server type. Really, this logic all needs to be encapsulated behind an Angular service...but I'm not yet in the habit of creating those :).

FYI, #39 gives some background about what versions are supported by what type.