yarn install issue - Githubissues

moos / wordpos

Part-of-speech utilities for node.js based on the WordNet database.

478 stars 41 forks source link

yarn install issue #21

Closed oliviertassinari closed 4 years ago

oliviertassinari commented 7 years ago

I have noticed the following behaviour trying to install wordpos with yarn.

During the first install

the post install script is triggered, populating wordnet-db fast index

During a consecutive, yarn thing get messy

yarn see that the wordnet-db folder changed and reset it to his original state. However, as wordpos is still the same, his postinstall script isn't call.
At that point, wordpos can't no longer be used as missing the fast index.

oliviertassinari commented 7 years ago

I use the following fix for now in the package on userspace.

package.json

  "postinstall": "cd node_modules/wordpos && yarn postinstall"`

oliviertassinari commented 7 years ago

However, we lose ~1s for each yarn interaction, not great

buildbreakdo commented 6 years ago

Hmm.. ran into this too. After running your script seeing ENOENT: no such file or directory, scandir '/dict'.

maxmatthews commented 6 years ago

Any movement on this? Still having this issue and yarn only seems to be growing in popularity. The postinstall fix is a fine temp one, but is definitely a performance hit.

moos commented 5 years ago

I can't reproduce with latest yarn:

~/dev/tmp/wordpos-yarn-test$ yarn
yarn install v1.9.4
(node:81202) ExperimentalWarning: The fs.promises API is experimental
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
[4/4] 📃  Building fresh packages...
success Saved lockfile.
✨  Done in 5.50s.

~/dev/tmp/wordpos-yarn-test$ ls node_modules/wordnet-db/dict/
data.adj             data.verb            fast-index.noun.json index.adv            index.verb
data.adv             fast-index.adj.json  fast-index.verb.json index.noun
data.noun            fast-index.adv.json  index.adj            index.sense

Please try updating yarn.

oliviertassinari commented 5 years ago

@moos Did you run yarn twice?

moos commented 5 years ago

Yes -- I did. I was able to repro with earlier version of yarn, but not with latest.

maxmatthews commented 5 years ago

~~Can confirm that this is fixed in yarn>1.9.4. Thanks for checking this @moos

maxmatthews commented 5 years ago

Take it back. Just added a package and got a no such file or directory /node_modules/wordnet-db/dict/fast-index.noun.json'. Adding back the post install line got me back up and running