moosa-r / rbioapi

rbioapi: User-Friendly R Interface to Biologic Web Services' API
https://rbioapi.moosa-r.com/
GNU General Public License v3.0
17 stars 1 forks source link

STRING version outdated #1

Closed stephan-hutter closed 2 years ago

stephan-hutter commented 3 years ago

Hi,

just wanted to let you know, that STRING is currently on version 11.5, while the API still calls version 11.0.

It would be great if there was an option to explicitly set the STRING version for API calls.

Cheers, Stephan

moosa-r commented 3 years ago

Dear Stephan,

Thank you for raising this issue. I've updated rbioapi to connect to STRING v11.5 (See commit 84154cbc5ed73a7733541aef3255da135f99f427).

About explicitly setting the version, It is possible to add an argument "version" to the STRING functions. I will investigate whether this will introduce any backward compatibility issues or other complications. If this is not the case, I will implement it as soon as possible. Thank you very much for your suggestion.

Regards, Moosa

moosa-r commented 3 years ago

Dear Stephan

It appears that the API methods of STRING are not consistent between versions. Although implementing the "version" argument and even handling the inconsistencies is easy (rbioapi's argument check supports conditional criteria), this may make things complicated for the users, which contradicts my purpose of building this package. So I'm a bit hesitant to add this feature and prefer only to maintain the latest version.

Bests, Moosa