moose-team / friends

:tv: P2P chat powered by the web.
http://moose-team.github.io/friends/
MIT License
3.17k stars 341 forks source link

Use standard github user in gitconfig #160

Closed ungoldman closed 8 years ago

ungoldman commented 8 years ago

This has been bugging me since the early days but I figured it was too tiny a nitpick to bring up, but since development is at a standstill, now's the perfect time!

A standard for storing github user information already existed before this project, all the way back in 2008.

git config --global github.user defunkt

https://github.com/blog/180-local-github-config

I think we should use that instead of git config --global git.username to avoid unnecessary duplication of the same info in .gitconfig files the world over.

beaugunderson commented 8 years ago

makes total sense, should probably be filed against github-current-user though:

https://github.com/beaugunderson/github-current-user/blob/master/github-current-user.js#L14

ungoldman commented 8 years ago

:+1: will do

ungoldman commented 8 years ago

Thanks @beaugunderson! Bumped github-current-user so both forms are now supported. Some extra googling tells me both forms are out there in abundance, the former one a bit moreso.

¯_(ツ)_/¯