search

moose-team / friends

:tv: P2P chat powered by the web.
http://moose-team.github.io/friends/
MIT License
3.17k stars 342 forks source link

Please add support for ed25519 keys. #76

Open okket opened 9 years ago

okket commented 9 years ago

Is there any reason why you do not support them? They are official part of OpenSSH since 6.5:

http://www.openssh.com/txt/release-6.5

They are blessed by DJB:

http://ed25519.cr.yp.to/

And Github does support them.

beaugunderson commented 9 years ago

two reasons:

i also thought the node ssh-agent module only supported RSA keys, but it looks like the name is just wrong:

https://github.com/mcavage/node-ssh-agent/blob/master/lib/ssh_agent_client.js#L13

in the ssh-agent protocol SSH2_AGENTC_REQUEST_IDENTITIES is 11, but that field is named SSH_AGENTC_REQUEST_RSA_IDENTITIES; i thought that module only returned RSA keys but that doesn't appear to be the case, so i think a tweak in ghsign would fix this (but probably low priority since most people are still using RSA keys)

calvinmetcalf commented 9 years ago

does node crypto support them for signing?

max-mapper commented 9 years ago

I opened an issue in ghsign: https://github.com/mafintosh/ghsign/issues/5