moosetechnology / Moose

MOOSE - Platform for software and data analysis.
https://moosetechnology.github.io/moose-wiki
MIT License
136 stars 34 forks source link

Glamour easel and GTDebugger #1034

Closed seandenigris closed 9 years ago

seandenigris commented 9 years ago

Originally reported on Google Code with ID 1034

Hi!

I have spotted an important bug. If I enter the following in the Glamour Roassal easel:
view nodes: (1 to: 20).
self halt.

A debugger is open, but I cannot step in. Apparently the code source is not accessible.
This is a major regression...

Reported by alexandre.bergel on 2013-12-19 09:25:19

seandenigris commented 9 years ago
This is not related to the debugger, but to the changes induced Opal. It seems that
GLMDoItContext is not compliant anymore.

Can someone more knowledgeable take a look at this?

Reported by tudor@tudorgirba.com on 2013-12-19 11:00:05

seandenigris commented 9 years ago
The problem appears because the code is compiled into a method without source code,
and then when it's executed the source code seems to be needed. It can be solved by
setting a notifier object when calling the compiler: in GLMRoassalEasel>>evaluate:in:for:

Smalltalk compiler 
            evaluate: script 
            in: context 
            to: context
            notifying: self
            ifFail: [^ #failedDoit]

Seems to work, but I'm not sure exactly what the notifier should do.

Reported by chisvasileandrei on 2013-12-19 14:04:46

seandenigris commented 9 years ago
Added the fix to all other esels

Reported by chisvasileandrei on 2013-12-20 14:07:06

seandenigris commented 9 years ago
If I do in the Roassal Easel (or other ones):

view halt

I get this at the moment:

DoItIn: ThisContext
    ^ (ThisContext namedTempAt: 1) halt 

Can we not get the actual source?

Reported by tudor@tudorgirba.com on 2014-01-10 04:14:57

seandenigris commented 9 years ago
As far as I can tell, this is fixed now. Let me know if you still have problems in this
area.

Reported by tudor@tudorgirba.com on 2014-10-04 06:00:46