search

moosetechnology / Moose

MOOSE - Platform for software and data analysis.
https://moosetechnology.github.io/moose-wiki
MIT License
135 stars 34 forks source link

TextPresentation should update rendering when text port is populated #1046

Closed seandenigris closed 5 years ago

seandenigris commented 9 years ago

Originally reported on Google Code with ID 1046

This should update the rendering to '42':

    composite := GLMCompositePresentation new with: [:a | a text ].
    composite openOn: 'fourtytwo'.
    composite first text: '42'.

Reported by tudor@tudorgirba.com on 2014-02-08 23:15:02

seandenigris commented 9 years ago

Reported by tudor@tudorgirba.com on 2014-02-08 23:23:17

seandenigris commented 9 years ago 
Reverted the change for now.

Name: Glamour-Morphic-Renderer-TudorGirba.225
Author: TudorGirba
Time: 10 February 2014, 6:39:53.053388 am
UUID: f7f54f9b-4177-4e87-8751-5d7c7e616dd2
Ancestors: Glamour-Morphic-Renderer-TudorGirba.224

commented out the text updating because it seems to disturb copy-pasting and cmd+shift+left
arrow :(

Issue 1046: TextPresentation should update rendering when text port is populated

Reported by tudor@tudorgirba.com on 2014-02-10 05:40:10

seandenigris commented 9 years ago 
The problem is located in the commented code from below:

GLMMorphicTextRenderer>>actOnContextChanged: ann 
    ann property = #selectionInterval
        ifTrue: [ 
            ann value notNil 
                ifTrue: [textMorph setSelection: ann value ]
                ifFalse: [textMorph setSelection: (1 to: 0)] ].
"   self flag: 'somehow this disturbs copy paste and cmd+shift+left selection'.
    ann property = #text
        ifTrue: [ 
            textMorph announcer suspendAll: {GLMTextChanged} while: [ 
                    textModel changedText: ann value ] ]"

Reported by tudor@tudorgirba.com on 2014-02-10 05:40:46

seandenigris commented 9 years ago

Reported by tudor@tudorgirba.com on 2014-11-25 07:34:23