search

moosetechnology / Moose

MOOSE - Platform for software and data analysis.
https://moosetechnology.github.io/moose-wiki
MIT License
135 stars 34 forks source link

FamixDeprecatedSlot still needed ? #2537

Open NicolasAnquetil opened 3 weeks ago

NicolasAnquetil commented 3 weeks ago

We could remove it may be ?

Or rename it ? (comment: "I am a slot used when the usage of an instance variable should be deprecated.")

jecisc commented 2 weeks ago

It's currently not used but it could have its usage in the future.

We used it for example when we removed some relations but the users could use the relations in their own subclasses. To not break everything we used the deprecated slot to keep them.

I don't have a strong opinion on keeping or removing them. @ClotildeToullec any opinion?

ClotildeToullec commented 2 weeks ago

No strong opinion either.

The fact that it is not currently used is not really relevant in itself; it's not often used by design. However it should be removed if we never use it.

How would you rename it Nicolas? Maybe a better comment?