search

moosetechnology / Moose

MOOSE - Platform for software and data analysis.
https://moosetechnology.github.io/moose-wiki
MIT License
136 stars 34 forks source link

RORubberband with target highlighting #852

Closed seandenigris closed 9 years ago

seandenigris commented 9 years ago

Originally reported on Google Code with ID 852

I have added highlighting of target elements to RORubberband - changeset attached. Note
changeset is against Roassal-AlexandreBergel.343.mcz since .344 breaks something.

Note2, I renamed RORubberbanding to RORubberband.  I had originally been tossing up
between the two, and under further consideration I think the latter is more appropriate.
 The former will need to be manually removed.

Reported by benjamin.t.coman on 2012-10-14 15:51:14

seandenigris commented 9 years ago 
It appears that the problem with .344 might just be something at my end.  Downloading
moose4.7 just now that includes .344 has no problem.

Reported by benjamin.t.coman on 2012-10-14 18:46:11

seandenigris commented 9 years ago 
Tracked the problem down - due to version .344 adding the ivar 'offset' to 
ROShorterDistanceAttachPoint and also...
----
ROShorterDistanceAttachPoint>>initialize
    super initialize.
    offset := 0.
----

but ROAbstractLine>>initialize uses 'ROShorterDistanceAttachPoint instance' to 
get a cached object...
----
ROShorterDistanceAttachPoint >>instance
    instance ifNil: [ instance := self new ].
    ^ instance
----

so the offset ivar of the cached object was 'nil' rather than the expected '0', 
and fixed with...
ROShorterDistanceAttachPoint resetInstance

Reported by benjamin.t.coman on 2012-10-15 13:37:37

seandenigris commented 9 years ago 
I have updated this to Roassal-BenComan.348 based off latest Roassal-AlexandreBergel.345.
 It is attached as a mcz since I was having trouble using Change Sorter properly.

Renamed RORubberBanding to RORubberBand.
Added target highlighting to RORubberBand.
Added RORemoveEdge.

Reported by benjamin.t.coman on 2012-10-15 13:42:37

seandenigris commented 9 years ago 
An alternative implementation that exposes more end-user control of actions applied
to items moving into and out of the target selection (see attached .349). 

Created ROSelection. Modified RORubberBand and ROExample>>rubberBandOn: to use this.
 The side-effect is slightly streamlined  RORubberBand>>initializeElement: and reduced
RORubberBand ivars.

Reported by benjamin.t.coman on 2012-10-15 14:35:59

seandenigris commented 9 years ago 
Some cleanup of RORubberBand that I missed.

Reported by benjamin.t.coman on 2012-10-15 15:23:59

seandenigris commented 9 years ago 
In Roassal 1.166. Thanks Ben!

Reported by alexandre.bergel on 2012-10-15 16:18:30

seandenigris commented 9 years ago

Reported by tudor@tudorgirba.com on 2013-03-03 13:04:50