search

moosingin3space / wksp-for-firefox

Workspaces for Firefox, inspired by those in Linux desktop environments.
Apache License 2.0
9 stars 2 forks source link

Suggestion - focus the cursor on the "Filter" text box #6

Open SpitFire-666 opened 6 years ago

SpitFire-666 commented 6 years ago

When you click the button on the toolbar to open WorkSpace Palette, you have to click into the text box to begin searching. If you could open WP with the keyboard, then have keyboard input focused on the text box, it would make it a lot faster and no mouse required to find/switch to tabs!

moosingin3space commented 6 years ago

What version of Firefox and operating system are you using? In my development environment running 60 Developer Edition, the text field is always focused when the palette opens.

SpitFire-666 commented 6 years ago

Thanks for the quick response! FF 59.0.2 x64, Win7 SP1 x64.

EDIT: Just tested on Win 2012 R2 with FF 59.0.2 x64, same behaviour (text field not focused by default). Thanks.

moosingin3space commented 6 years ago

Just tested on Fedora 27 with 59, and focusing is inconsistent. Curious! Gonna need to take a closer look. Can you try it in Developer Edition so I can rule out the platform as the problem?

moosingin3space commented 6 years ago

Also, on my laptop, it properly focuses the text box when I activate it from the keyboard, but not by clicking on the button. Can you reproduce that?

SpitFire-666 commented 6 years ago

Tried it on v61 FF and it works as expected. Since my other testing is on prod FF (< v60), keyboard shortcuts don't work yet (from what i've read?) so I can only activate by clicking the button.

EDIT looks like Ctrl+Space IS working in v59 - it's just that the text field isn't focused. It's focused fine on v61.

moosingin3space commented 6 years ago

I honestly have no idea why this would be happening. Going to see if I've got a timing discrepancy between the call to focus and the popup loading.

SpitFire-666 commented 6 years ago

Good news - after updating to FFv60, the focus is on the cursor box! Looks like this is no longer an issue.