search

mootools / slick

Standalone CSS Selector Parser and Engine. An official MooTools project.
MIT License
150 stars 22 forks source link

slick: Correct invalid selectors in various SlickSpec specs. [jddalton] #36

Closed jdalton closed 10 years ago

subtleGradient commented 13 years ago

There's some good stuff in here. I don't want to just comment out a bunch of stuff though. Let's either remove them or not.

As far as invalid selectors go, many engines are intentionally lenient about that stuff. How would you recommend including tests for selectors that are not W3C valid?

jdalton commented 13 years ago

I would make a separate spec file for them, maybe a custom spec. As a side note on leniency, the correct valid selectors should be promoted as they will work on the QSA fork without having to fallback to the manual dom iteration fork of engines.

SergioCrisostomo commented 10 years ago

@jdalton why did you close this? (something else than the "age" factor?)

jdalton commented 10 years ago

Just pruning dead PRs (those that have been open several years).

SergioCrisostomo commented 10 years ago

@jdalton well I can't blame you... but if they are good ideas would be better to have them open. I was actually checking the specs last week and was thinking of putting them on travis like Fabio once suggested. Core has no Slick specs, so we still need this.

Cheers