Ensure that no deprecation warnings are thrown in FF (getAttributeNode)

mootools / slick

Standalone CSS Selector Parser and Engine. An official MooTools project.

MIT License

149 stars 22 forks source link

Ensure that no deprecation warnings are thrown in FF (getAttributeNode) #61

Open schnix opened 13 years ago

schnix commented 13 years ago

both functions are deprecated in DOM4.

refering to: https://developer.mozilla.org/en/DOM/Attr

jsfiddle: http://jsfiddle.net/schnix/9agrB/

ff7 throws a warning ie7 throws an error

havent installed more browsers atm

schnix

arian commented 13 years ago

FF7 works fine for me..

subtleGradient commented 13 years ago

Node.getAttributeNode is not deprecated. Attr.getAttributeNode is deprecated.

e.g. el.getAttributeNode('foo').getAttributeNode

It's likely warning because Attr.specified is also deprecated.

We definitely should stop Firefox from showing a warning if possible. The trick is to do that with a feature test and not sniff the UA string or whatever. Using Attr.specified is absolutely essential in some browsers.

garyee commented 9 years ago

The Problem is still there... (using 1.5.5 and FF 36.0.1)