search

moov-io / ach

ACH implements a reader, writer, and validator for Automated Clearing House (ACH) files. The HTTP server is available in a Docker image and the Go package is available.
https://moov-io.github.io/ach/
Apache License 2.0
452 stars 150 forks source link

fix: process entry rune-by-rune without casting between string -> rune -> string #1305

Closed adamdecaf closed 10 months ago

adamdecaf commented 10 months ago

Converting between types is costly and can waste a lot of memory. Go lets us iterate through strings rune-by-rune, which helps to reduce some conversions.

adamdecaf commented 10 months ago

cc @wadearnold

codecov-commenter commented 10 months ago

Codecov Report

Merging #1305 (baed52a) into master (c35e195) will increase coverage by 0.03%. The diff coverage is 97.05%.

:exclamation: Current head baed52a differs from pull request most recent head 6da4042. Consider uploading reports for the commit 6da4042 to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1305 +/- ## ========================================== + Coverage 88.48% 88.52% +0.03% ========================================== Files 73 73 Lines 7089 7111 +22 ========================================== + Hits 6273 6295 +22 Misses 480 480 Partials 336 336 ```