moov-io / ach

ACH implements a reader, writer, and validator for Automated Clearing House (ACH) files. The HTTP server is available in a Docker image and the Go package is available.
https://moov-io.github.io/ach/
Apache License 2.0
452 stars 150 forks source link

API: fedWireMessage is an object, not an array #1331

Closed DennyWeinberg closed 9 months ago

DennyWeinberg commented 9 months ago

ACH Version

v1.32.0

What were you trying to do?

I'm creating, parsing and validating ACH files that contains multiple transactions.

What did you expect to see?

A parsed JSON structure containing all my fed wire messages.

What did you see?

A parsed JSON structure containing ONLY the last fed wire message, others are lost.

The problem is, the API JSON is not a list: https://moov-io.github.io/wire/api/#post-/files/create

{
  "ID": "3f2d23ee214",
  "fedWireMessage": {
    "ID": "3f2d23ee214",
...

So how could that hold multiple messages? fedWireMessage should be an array, not an object.

How can we reproduce the problem?

  1. Call the create API with an ACH file that contains multiple messages
  2. Check the response, only one message is returned obviously because it's not an array
DennyWeinberg commented 9 months ago

Sorry wrong repo.

DennyWeinberg commented 9 months ago

Closed