search

moov-io / ach

ACH implements a reader, writer, and validator for Automated Clearing House (ACH) files. The HTTP server is available in a Docker image and the Go package is available.
https://moov-io.github.io/ach/
Apache License 2.0
447 stars 150 forks source link

Generate jni bindings #1380

Closed midepeter closed 3 months ago

midepeter commented 4 months ago

This PR is to realated to initial !1327 for generating java bindings for the ach library

adamdecaf commented 4 months ago

Can you include only the changes for JNI interop in this PR?

midepeter commented 4 months ago

Yes, that was what I intended to do ..

I think I had some commit issues … not sure why the commits mixed up but I fixed it up manually.

midepeter commented 4 months ago

@adamdecaf

could you help take a look at the update. Thank you

midepeter commented 4 months ago

@adamdecaf

Trust you are doing great.

Hopefully this passes the pending checks but i need a review from you on what i did to know if it fits for merging or if there is something more to do.

Thank you.

midepeter commented 3 months ago

@adamdecaf

The ubuntu build is failing due to the test coverage. I though since we were porting the library the unit testing was not compulsory. I am not sure what I should do in this case.

jason53 commented 3 months ago

@adamdecaf were these changes never merged in? i am just following up from our discussion. https://github.com/moov-io/ach/discussions/1373#discussioncomment-8619567

adamdecaf commented 3 months ago

Correct they were not merged in. We still need to figure out a way to setup types/classes so the JNI layer supports them all.

I've tried another way but there are tons of unsupported classes, which is annoying. See https://github.com/moov-io/ach/pull/1406