search

moov-io / ach

ACH implements a reader, writer, and validator for Automated Clearing House (ACH) files. The HTTP server is available in a Docker image and the Go package is available.
https://moov-io.github.io/ach/
Apache License 2.0
446 stars 149 forks source link

feat: preserve IAT BatchControl.CompanyIdentification when parsing from json #1407

Closed joanofxyz closed 2 months ago

joanofxyz commented 2 months ago

The main motivation for this PR is the fact that, using the achcli tool to convert from json to ach, there's no way to set the BatchControl.CompanyIdentification for IAT files, since they don't have the CompanyIdentification in the BatchHeader. Unless I overlooked something, this seemed like a straightforward fix and I added enough tests for the use case I am trying to cover.

(@adamdecaf contribution guide asked to tag maintainers)

adamdecaf commented 2 months ago

Thank you for the fix!

adamdecaf commented 2 months ago

@joanofxyz can you nil-check those test results?

joanofxyz commented 2 months ago

@adamdecaf sure thing! I think it's fixed now

adamdecaf commented 2 months ago

Released in https://github.com/moov-io/ach/releases/tag/v1.37.4