n2847
commented
1 week ago In addition to the other questions mentioned in the pull request, I wondered about the "-bench=BenchmarkWEBDebitRead" Benchmarks example. That particular "go test" call doesn't reference an executable. Should it?
Here are the other questions that were included in the merge request:
-
The CONTRIBUTING.md file mentions a google group. Does that group still exist?
-
It doesn’t look like anything has happened with the "Travis-CI" pipeline in quite some time (latest run was 4 years ago). Should references to it be removed?
-
I couldn't find a reference to an updated PNC ACH File Specification. Any idea where one might be?
@adamdecaf
adamdecaf
Made some small changes to ACH's CONTRIBUTING.md file, including fixing broken links:
Fixed the “AUTHORS” link. The current link results in a 404 since the file is called “AUTHORS”, not “AUTHORS.md”.
Updated the old “Go Code Review Comments” link so that the user isn’t required to manually redirect their browser.
Fixed the numbering of instructions for adding SEC types (it should start with the number "1").
Updated the "readACH" link, which currently gives a 404.
Updated the "writeACH" link, which currently gives a 404.
Updated several "Format Specification" links.
Fixed some misspellings (for example, Cheny->Cheney, buide->guide, Wikipeda->Wikipedia)
Changed the “I” in the word “FIle” from uppercase to lowercase.
Changed one instance of “Nacha” to “NACHA” for consistency and correctness.
Changed the scheme in the Wikipedia link from “http” to “https” in order to avoid an automatic redirect.
While the aforementioned changes should be good, there are still some questions that I have: