moov-io / achgateway

Payment gateway enabling automated ACH operations in a distributed and fault tolerant way.

https://moov-io.github.io/achgateway/

Apache License 2.0

52 stars 19 forks source link

fix: always ack message #138

Closed yordis closed 1 year ago

yordis commented 1 year ago

Changes

Always ack message to move the consumer offset forward.

Why Are Changes Being Made

Please validate my assumption If you must ack the message to move the consumer offset regardless of a failure, you can potentially queue the system forever when a loss is expected.

The failures are being logged today, so it should be good from that end.

The final solution would be to move the message into A DLQ (Dead-Letter Queue) in the case of a failure.

adamdecaf commented 1 year ago

I've combined this into https://github.com/moov-io/achgateway/pull/140