moov-io / achgateway

Payment gateway enabling automated ACH operations in a distributed and fault tolerant way.
https://moov-io.github.io/achgateway/
Apache License 2.0
52 stars 19 forks source link

test: verify we reconnect from flakey subscriptions #162

Closed adamdecaf closed 1 year ago

adamdecaf commented 1 year ago

We've been seeing this issue of infinite logging when the stream subscription fails. After https://github.com/moov-io/achgateway/pull/160 added reconnect logic we should verify that cycle is working.

codecov-commenter commented 1 year ago

Codecov Report

Base: 41.23% // Head: 40.85% // Decreases project coverage by -0.38% :warning:

Coverage data is based on head (f63a08f) compared to base (2982c4f). Patch coverage: 42.42% of modified lines in pull request are covered.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #162 +/- ## ========================================== - Coverage 41.23% 40.85% -0.38% ========================================== Files 90 90 Lines 3912 3931 +19 ========================================== - Hits 1613 1606 -7 - Misses 1997 2025 +28 + Partials 302 300 -2 ``` | [Impacted Files](https://codecov.io/gh/moov-io/achgateway/pull/162?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io) | Coverage Δ | | |---|---|---| | [internal/pipeline/pipeline.go](https://codecov.io/gh/moov-io/achgateway/pull/162?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io#diff-aW50ZXJuYWwvcGlwZWxpbmUvcGlwZWxpbmUuZ28=) | `0.00% <0.00%> (ø)` | | | [internal/pipeline/file\_receiver.go](https://codecov.io/gh/moov-io/achgateway/pull/162?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io#diff-aW50ZXJuYWwvcGlwZWxpbmUvZmlsZV9yZWNlaXZlci5nbw==) | `20.47% <42.30%> (-5.32%)` | :arrow_down: | | [internal/environment.go](https://codecov.io/gh/moov-io/achgateway/pull/162?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io#diff-aW50ZXJuYWwvZW52aXJvbm1lbnQuZ28=) | `51.20% <100.00%> (+0.41%)` | :arrow_up: | | [internal/incoming/stream/subscription.go](https://codecov.io/gh/moov-io/achgateway/pull/162?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io#diff-aW50ZXJuYWwvaW5jb21pbmcvc3RyZWFtL3N1YnNjcmlwdGlvbi5nbw==) | `35.71% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.