codecov-commenter
commented
1 year ago Codecov Report
Base: 41.23% // Head: 40.88% // Decreases project coverage by -0.35% :warning:
Coverage data is based on head (
e3d0576) compared to base (2982c4f). Patch coverage: 37.93% of modified lines in pull request are covered.
:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #163 +/- ## ========================================== - Coverage 41.23% 40.88% -0.35% ========================================== Files 90 90 Lines 3912 3928 +16 ========================================== - Hits 1613 1606 -7 - Misses 1997 2022 +25 + Partials 302 300 -2 ``` | [Impacted Files](https://codecov.io/gh/moov-io/achgateway/pull/163?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io) | Coverage Δ | | |---|---|---| | [internal/pipeline/manual\_cutoff\_times.go](https://codecov.io/gh/moov-io/achgateway/pull/163?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io#diff-aW50ZXJuYWwvcGlwZWxpbmUvbWFudWFsX2N1dG9mZl90aW1lcy5nbw==) | `73.21% <0.00%> (-4.97%)` | :arrow_down: | | [internal/pipeline/pipeline.go](https://codecov.io/gh/moov-io/achgateway/pull/163?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io#diff-aW50ZXJuYWwvcGlwZWxpbmUvcGlwZWxpbmUuZ28=) | `0.00% <0.00%> (ø)` | | | [internal/pipeline/file\_receiver.go](https://codecov.io/gh/moov-io/achgateway/pull/163?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io#diff-aW50ZXJuYWwvcGlwZWxpbmUvZmlsZV9yZWNlaXZlci5nbw==) | `20.87% <50.00%> (-4.92%)` | :arrow_down: | | [internal/environment.go](https://codecov.io/gh/moov-io/achgateway/pull/163?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io#diff-aW50ZXJuYWwvZW52aXJvbm1lbnQuZ28=) | `51.20% <100.00%> (+0.41%)` | :arrow_up: | | [internal/upload/sftp.go](https://codecov.io/gh/moov-io/achgateway/pull/163?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io#diff-aW50ZXJuYWwvdXBsb2FkL3NmdHAuZ28=) | `66.36% <0.00%> (+0.89%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io):umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
We've ran into a few problems internally when accidentally not including shardNames. Either by accident or typo it is too easy to trigger all shards, which is rarely desired. It seems safer to require at least one shard name rather than default to all processing all shards.