moov-io / achgateway

Payment gateway enabling automated ACH operations in a distributed and fault tolerant way.
https://moov-io.github.io/achgateway/
Apache License 2.0
52 stars 19 forks source link

Improve shard error logging #164

Closed adamdecaf closed 1 year ago

adamdecaf commented 1 year ago

This change ensures logs are emitted for files during upload.

codecov-commenter commented 1 year ago

Codecov Report

Base: 40.79% // Head: 40.77% // Decreases project coverage by -0.03% :warning:

Coverage data is based on head (0f7eafe) compared to base (c249993). Patch coverage: 0.00% of modified lines in pull request are covered.

:exclamation: Current head 0f7eafe differs from pull request most recent head b27de55. Consider uploading reports for the commit b27de55 to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #164 +/- ## ========================================== - Coverage 40.79% 40.77% -0.03% ========================================== Files 90 90 Lines 3932 3939 +7 ========================================== + Hits 1604 1606 +2 - Misses 2027 2033 +6 + Partials 301 300 -1 ``` | [Impacted Files](https://codecov.io/gh/moov-io/achgateway/pull/164?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io) | Coverage Δ | | |---|---|---| | [internal/pipeline/metrics.go](https://codecov.io/gh/moov-io/achgateway/pull/164?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io#diff-aW50ZXJuYWwvcGlwZWxpbmUvbWV0cmljcy5nbw==) | `41.66% <0.00%> (-29.77%)` | :arrow_down: | | [internal/pipeline/pipeline.go](https://codecov.io/gh/moov-io/achgateway/pull/164?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io#diff-aW50ZXJuYWwvcGlwZWxpbmUvcGlwZWxpbmUuZ28=) | `0.00% <0.00%> (ø)` | | | [internal/upload/sftp.go](https://codecov.io/gh/moov-io/achgateway/pull/164?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io#diff-aW50ZXJuYWwvdXBsb2FkL3NmdHAuZ28=) | `66.36% <0.00%> (+0.89%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.