search

moov-io / achgateway

Payment gateway enabling automated ACH operations in a distributed and fault tolerant way.
https://moov-io.github.io/achgateway/
Apache License 2.0
52 stars 19 forks source link

test: verify odfi processor handles files with mixed returns and corrections #167

Closed adamdecaf closed 1 year ago

adamdecaf commented 1 year ago

Follow up of https://github.com/moov-io/ach/pull/1203 to verify the behavior works.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 24.39% and project coverage change: +1.86 :tada:

Comparison is base (7868868) 40.68% compared to head (28e5895) 42.55%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #167 +/- ## ========================================== + Coverage 40.68% 42.55% +1.86% ========================================== Files 90 90 Lines 3957 3974 +17 ========================================== + Hits 1610 1691 +81 + Misses 2048 1974 -74 - Partials 299 309 +10 ``` | [Impacted Files](https://codecov.io/gh/moov-io/achgateway/pull/167?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io) | Coverage Δ | | |---|---|---| | [internal/events/service.go](https://codecov.io/gh/moov-io/achgateway/pull/167?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io#diff-aW50ZXJuYWwvZXZlbnRzL3NlcnZpY2UuZ28=) | `0.00% <0.00%> (ø)` | | | [internal/events/service\_stream.go](https://codecov.io/gh/moov-io/achgateway/pull/167?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io#diff-aW50ZXJuYWwvZXZlbnRzL3NlcnZpY2Vfc3RyZWFtLmdv) | `23.07% <0.00%> (-4.20%)` | :arrow_down: | | [internal/service/model\_events.go](https://codecov.io/gh/moov-io/achgateway/pull/167?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io#diff-aW50ZXJuYWwvc2VydmljZS9tb2RlbF9ldmVudHMuZ28=) | `15.00% <ø> (ø)` | | | [pkg/models/events.go](https://codecov.io/gh/moov-io/achgateway/pull/167?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io#diff-cGtnL21vZGVscy9ldmVudHMuZ28=) | `42.16% <34.48%> (-5.66%)` | :arrow_down: | ... and [4 files with indirect coverage changes](https://codecov.io/gh/moov-io/achgateway/pull/167/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io) Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.