moov-io / achgateway

Payment gateway enabling automated ACH operations in a distributed and fault tolerant way.
https://moov-io.github.io/achgateway/
Apache License 2.0
52 stars 19 forks source link

incoming/odfi: don't emit IncomingFile events for empty ACH files #177

Closed adamdecaf closed 1 year ago

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.40 :tada:

Comparison is base (520d0a6) 41.63% compared to head (83310f0) 42.03%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #177 +/- ## ========================================== + Coverage 41.63% 42.03% +0.40% ========================================== Files 90 90 Lines 4028 4032 +4 ========================================== + Hits 1677 1695 +18 + Misses 2044 2025 -19 - Partials 307 312 +5 ``` | [Impacted Files](https://app.codecov.io/gh/moov-io/achgateway/pull/177?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io) | Coverage Δ | | |---|---|---| | [internal/incoming/odfi/incoming.go](https://app.codecov.io/gh/moov-io/achgateway/pull/177?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io#diff-aW50ZXJuYWwvaW5jb21pbmcvb2RmaS9pbmNvbWluZy5nbw==) | `58.97% <100.00%> (+41.83%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/moov-io/achgateway/pull/177/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.