search

moov-io / achgateway

Payment gateway enabling automated ACH operations in a distributed and fault tolerant way.
https://moov-io.github.io/achgateway/
Apache License 2.0
52 stars 19 forks source link

feat: add API for publishing FileUploaded on isolated directories #184

Closed adamdecaf closed 1 year ago

adamdecaf commented 1 year ago

Fixes: https://github.com/moov-io/achgateway/issues/183

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 41.93% and project coverage change: +3.35 :tada:

Comparison is base (d985c0c) 43.04% compared to head (d403362) 46.40%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #184 +/- ## ========================================== + Coverage 43.04% 46.40% +3.35% ========================================== Files 87 88 +1 Lines 3956 3987 +31 ========================================== + Hits 1703 1850 +147 + Misses 1938 1781 -157 - Partials 315 356 +41 ``` | [Impacted Files](https://app.codecov.io/gh/moov-io/achgateway/pull/184?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io) | Coverage Δ | | |---|---|---| | [pkg/models/events.go](https://app.codecov.io/gh/moov-io/achgateway/pull/184?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io#diff-cGtnL21vZGVscy9ldmVudHMuZ28=) | `48.42% <0.00%> (-1.58%)` | :arrow_down: | | [internal/pipeline/events\_api.go](https://app.codecov.io/gh/moov-io/achgateway/pull/184?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io#diff-aW50ZXJuYWwvcGlwZWxpbmUvZXZlbnRzX2FwaS5nbw==) | `44.44% <44.44%> (ø)` | | | [internal/pipeline/file\_receiver.go](https://app.codecov.io/gh/moov-io/achgateway/pull/184?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io#diff-aW50ZXJuYWwvcGlwZWxpbmUvZmlsZV9yZWNlaXZlci5nbw==) | `53.01% <100.00%> (+11.47%)` | :arrow_up: | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/moov-io/achgateway/pull/184/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

adamdecaf commented 1 year ago

I'm adding FileReceiver tests in https://github.com/moov-io/achgateway/issues/182 which will help us test this endpoint too.