codecov-commenter
commented
1 year ago Codecov Report
Patch coverage: 100.00% and project coverage change: +0.01% :tada:
Comparison is base (
4c4bd09) 46.03% compared to head (9b4e059) 46.05%.
:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #189 +/- ## ========================================== + Coverage 46.03% 46.05% +0.01% ========================================== Files 87 87 Lines 3736 3722 -14 ========================================== - Hits 1720 1714 -6 + Misses 1710 1704 -6 + Partials 306 304 -2 ``` | [Files Changed](https://app.codecov.io/gh/moov-io/achgateway/pull/189?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io) | Coverage Δ | | |---|---|---| | [internal/upload/agent.go](https://app.codecov.io/gh/moov-io/achgateway/pull/189?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io#diff-aW50ZXJuYWwvdXBsb2FkL2FnZW50Lmdv) | `39.13% <ø> (+0.66%)` | :arrow_up: | | [internal/incoming/odfi/scheduler.go](https://app.codecov.io/gh/moov-io/achgateway/pull/189?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io#diff-aW50ZXJuYWwvaW5jb21pbmcvb2RmaS9zY2hlZHVsZXIuZ28=) | `31.76% <100.00%> (+0.81%)` | :arrow_up: | | [internal/pipeline/merging.go](https://app.codecov.io/gh/moov-io/achgateway/pull/189?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io#diff-aW50ZXJuYWwvcGlwZWxpbmUvbWVyZ2luZy5nbw==) | `60.73% <100.00%> (+0.24%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/moov-io/achgateway/pull/189/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io):umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
We're seeing issues when connections fail that aren't recoverable. Instead of keeping connections open and needing to check their errors/status let's make new connections when needed.Reading the full file restores previous behavior of
v0.23.1. We will continue to investigate a fix to not consume files in memory prior to when their contents are needed.