moov-io / achgateway

Payment gateway enabling automated ACH operations in a distributed and fault tolerant way.
https://moov-io.github.io/achgateway/
Apache License 2.0
52 stars 19 forks source link

odfi: read files in sequence to download #190

Closed adamdecaf closed 10 months ago

adamdecaf commented 10 months ago

Rather than reading all returned/recon/etc files at once retrieve and save them one at a time.

codecov-commenter commented 10 months ago

Codecov Report

Patch coverage: 45.91% and project coverage change: -0.29% :warning:

Comparison is base (db3b692) 46.03% compared to head (60053f7) 45.75%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #190 +/- ## ========================================== - Coverage 46.03% 45.75% -0.29% ========================================== Files 87 87 Lines 3736 3759 +23 ========================================== Hits 1720 1720 - Misses 1710 1733 +23 Partials 306 306 ``` | [Files Changed](https://app.codecov.io/gh/moov-io/achgateway/pull/190?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io) | Coverage Δ | | |---|---|---| | [internal/upload/agent.go](https://app.codecov.io/gh/moov-io/achgateway/pull/190?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io#diff-aW50ZXJuYWwvdXBsb2FkL2FnZW50Lmdv) | `38.46% <ø> (ø)` | | | [internal/upload/file.go](https://app.codecov.io/gh/moov-io/achgateway/pull/190?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io#diff-aW50ZXJuYWwvdXBsb2FkL2ZpbGUuZ28=) | `100.00% <ø> (ø)` | | | [internal/upload/mock\_agent.go](https://app.codecov.io/gh/moov-io/achgateway/pull/190?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io#diff-aW50ZXJuYWwvdXBsb2FkL21vY2tfYWdlbnQuZ28=) | `4.54% <0.00%> (-0.46%)` | :arrow_down: | | [internal/upload/retry.go](https://app.codecov.io/gh/moov-io/achgateway/pull/190?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io#diff-aW50ZXJuYWwvdXBsb2FkL3JldHJ5Lmdv) | `5.95% <0.00%> (-1.00%)` | :arrow_down: | | [internal/incoming/odfi/download.go](https://app.codecov.io/gh/moov-io/achgateway/pull/190?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io#diff-aW50ZXJuYWwvaW5jb21pbmcvb2RmaS9kb3dubG9hZC5nbw==) | `40.19% <35.71%> (-2.97%)` | :arrow_down: | | [internal/upload/sftp.go](https://app.codecov.io/gh/moov-io/achgateway/pull/190?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io#diff-aW50ZXJuYWwvdXBsb2FkL3NmdHAuZ28=) | `77.46% <71.42%> (ø)` | | | [internal/upload/ftp.go](https://app.codecov.io/gh/moov-io/achgateway/pull/190?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io#diff-aW50ZXJuYWwvdXBsb2FkL2Z0cC5nbw==) | `67.94% <90.47%> (ø)` | | | [internal/pipeline/aggregate.go](https://app.codecov.io/gh/moov-io/achgateway/pull/190?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io#diff-aW50ZXJuYWwvcGlwZWxpbmUvYWdncmVnYXRlLmdv) | `48.14% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.