search

moov-io / achgateway

Payment gateway enabling automated ACH operations in a distributed and fault tolerant way.
https://moov-io.github.io/achgateway/
Apache License 2.0
54 stars 19 forks source link

fix: add IAT Batches to populateHashes #201

Closed Boettner-eric closed 12 months ago

Boettner-eric commented 1 year ago

Changes

Why Are Changes Being Made

wadearnold commented 1 year ago

Can we get a test case to prove the new behavior?

Boettner-eric commented 1 year ago

Updated with a new test.

jasonbornsteinMOOV commented 12 months ago

Can you merge this in @adamdecaf

I can take care of it while @adamdecaf is out of the office

wadearnold commented 12 months ago

I approved the change. I meant that someone needs to merge and cut a release.

codecov-commenter commented 12 months ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (15b9eb4) 47.05% compared to head (ce1b44c) 47.10%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #201 +/- ## ========================================== + Coverage 47.05% 47.10% +0.05% ========================================== Files 87 87 Lines 3817 3821 +4 ========================================== + Hits 1796 1800 +4 Misses 1705 1705 Partials 316 316 ``` | [Files](https://app.codecov.io/gh/moov-io/achgateway/pull/201?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io) | Coverage Δ | | |---|---|---| | [internal/incoming/odfi/processor.go](https://app.codecov.io/gh/moov-io/achgateway/pull/201?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io#diff-aW50ZXJuYWwvaW5jb21pbmcvb2RmaS9wcm9jZXNzb3IuZ28=) | `72.94% <100.00%> (+1.33%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.