search

moov-io / achgateway

Payment gateway enabling automated ACH operations in a distributed and fault tolerant way.
https://moov-io.github.io/achgateway/
Apache License 2.0
54 stars 19 forks source link

Error handling fixes #203

Closed jasonbornsteinMOOV closed 11 months ago

jasonbornsteinMOOV commented 1 year ago

Changes

Fix to error handling for events

Why Are Changes Being Made

Better logging for error handling. Better support for events written without encryption to be decrypted.

The specific flow used to see this is the http://localhost:8080/shards/{shardName}/files/{fileID} endpoint, which produces an unencrypted event to pass internally for achgateway to consume, where the consumer expects the event to be encrypted.

wadearnold commented 1 year ago

I am confused as to: What were you trying to do?

What where you expecting and what did you get?

Where is the new test case for the new behavior?

This looks like a hack.

jasonbornsteinMOOV commented 1 year ago

I am confused as to: What were you trying to do?

What where you expecting and what did you get?

Where is the new test case for the new behavior?

This looks like a hack.

It is a bit of a hack - at least to prompt discussion. I'm trying to get the cancel event working for a manual ACH transfer getting cancelled.

Test case is still in progress.

I probably need to update the description a bit more.