search

moov-io / achgateway

Payment gateway enabling automated ACH operations in a distributed and fault tolerant way.
https://moov-io.github.io/achgateway/
Apache License 2.0
54 stars 19 forks source link

fix: dedup PagerDuty alerts off call stack, not errors #222

Closed adamdecaf closed 7 months ago

adamdecaf commented 8 months ago

We often see multiple errors from an ODFI scheduler run which should all be grouped together and delivered as a single alert. It does no good to spam someone with 50+ alerts for the same issue.

Screenshot 2024-02-02 at 15 43 16

codecov-commenter commented 8 months ago

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (b5db97e) 49.16% compared to head (1d04ad9) 49.09%.

Files Patch % Lines
internal/alerting/pagerduty.go 0.00% 13 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #222 +/- ## ========================================== - Coverage 49.16% 49.09% -0.08% ========================================== Files 89 89 Lines 4139 4145 +6 ========================================== Hits 2035 2035 - Misses 1773 1779 +6 Partials 331 331 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.