Closed adamdecaf closed 4 months ago
Attention: Patch coverage is 25.00000%
with 12 lines
in your changes are missing coverage. Please review.
Project coverage is 47.63%. Comparing base (
dc6e821
) to head (8365ce6
).
Files | Patch % | Lines |
---|---|---|
internal/pipeline/merging.go | 25.00% | 11 Missing and 1 partial :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Upgrading to moov-io/ach v1.35.0 as well, which has some performance improvements.
Without the moov-io/ach upgrade this benchmark reports
After upgrading moov-io/ach
There's still a lot of room for improvement in the merge files routine, but adding Filename to
FileUploaded
shouldn't hinder uploads.