search

moov-io / achgateway

Payment gateway enabling automated ACH operations in a distributed and fault tolerant way.
https://moov-io.github.io/achgateway/
Apache License 2.0
54 stars 19 forks source link

incoming/odfi: optionally store files in audit trail config #56

Closed adamdecaf closed 3 years ago

adamdecaf commented 3 years ago

This change will support storing inbound ODFI files (returns, corrections, etc) in an audittrail configuration. Doing so allows much better operational support for teams.

Also:

Issue: https://github.com/moov-io/achgateway/issues/26

codecov-commenter commented 3 years ago

Codecov Report

Merging #56 (6289d8b) into master (d7f17cd) will increase coverage by 0.02%. The diff coverage is 43.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #56      +/-   ##
==========================================
+ Coverage   39.90%   39.92%   +0.01%     
==========================================
  Files          79       80       +1     
  Lines        3057     3073      +16     
==========================================
+ Hits         1220     1227       +7     
- Misses       1582     1589       +7     
- Partials      255      257       +2
Impacted Files Coverage Δ
internal/audittrail/storage.go 100.00% <ø> (ø)
internal/pipeline/aggregate.go 25.34% <0.00%> (-0.18%) :arrow_down:
internal/service/model_audit.go 62.50% <ø> (+14.88%) :arrow_up:
internal/service/model_inbound.go 26.31% <ø> (ø)
internal/incoming/odfi/audit.go 35.71% <35.71%> (ø)
internal/audittrail/storage_mock.go 25.00% <40.00%> (ø)
internal/incoming/odfi/scheduler.go 34.78% <42.85%> (-0.52%) :arrow_down:
internal/incoming/odfi/processor.go 61.11% <50.00%> (-2.16%) :arrow_down:
internal/audittrail/storage_blob.go 60.86% <60.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d7f17cd...6289d8b. Read the comment docs.