search

moov-io / achgateway

Payment gateway enabling automated ACH operations in a distributed and fault tolerant way.
https://moov-io.github.io/achgateway/
Apache License 2.0
54 stars 19 forks source link

pipeline: attempt to start a new session on consul errors, always alert #65

Closed adamdecaf closed 2 years ago

adamdecaf commented 2 years ago

During cutoff time operations if there are consul errors they could be silently captured and logged, but not passed to the alerter. This means humans would not be sent an alert on errors and could miss cutoffs.

codecov-commenter commented 2 years ago

Codecov Report

Merging #65 (995f969) into master (e7e838a) will decrease coverage by 0.33%. The diff coverage is 44.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #65      +/-   ##
==========================================
- Coverage   41.40%   41.06%   -0.34%     
==========================================
  Files          79       79              
  Lines        3053     3078      +25     
==========================================
  Hits         1264     1264              
- Misses       1531     1555      +24     
- Partials      258      259       +1
Impacted Files Coverage Δ
internal/pipeline/merging.go 15.97% <0.00%> (-1.07%) :arrow_down:
internal/consul/session.go 75.00% <68.75%> (-5.00%) :arrow_down:
internal/consul/client.go 77.77% <100.00%> (ø)
internal/pipeline/file_receiver.go 22.58% <0.00%> (-11.83%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e7e838a...995f969. Read the comment docs.